[CI] Monorepo diff plugin for integration tests #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @pazone? 🙏
NOTE: |
7 tasks
|
/test |
|
/test |
1 similar comment
|
/test |
|
/test |
|
/test |
|
@cmacknz @blakerouse @rdner Could you please take a look at the list of watched paths? |
blakerouse
reviewed
Jun 12, 2024
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
* [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Cleanup * Cleanup * added missing watch paths (cherry picked from commit fd8d1ee) # Conflicts: # .buildkite/pull-requests.json
12 tasks
rdner
pushed a commit
that referenced
this pull request
Jun 14, 2024
#4922) * [CI] Monorepo diff plugin for integration tests (#4906) * [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * [CI] Monorepo diff plugin for integration tests * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Debug * Cleanup * Cleanup * added missing watch paths (cherry picked from commit fd8d1ee) # Conflicts: # .buildkite/pull-requests.json * Fixed conflicts * Fixed conflicts --------- Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use monorepo diff plugin to run integration tests for pull requests and branches.
The plugin specifies a list of watched paths for pull requests. If a PR modifies files under a path from the list - integration tests will be executed.
The main pipeline triggers
elastic-agent-extended-testingif all conditions are met:skip-itlabel is not setWhen a PR is merged to main or a release branch the integration tests will be triggered in any case
That's how it looks now:
Why is it important?
The previous approach wasn't flexible enough and the separate integration testing pipeline didn't allow to run integration tests conditionally due to required checks limitation.
Important: if we add
skip-itlabel - the PR will be mergeable without running integration tests.Checklist
./changelog/fragmentsusing the changelog toolAdditional checks
GITHUB_PULL_REQUEST_DRAFTenv variable to the build)/testcomment must trigger unit and integration tests also for draft PRsskip-itmust not trigger integration testsDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself