refactor: drop golang.org/x/lint

[kruskall]

What does this PR do?

drop golang.org/x/lint dependency

Why is it important?

the dependency was used to install the golint tool. The golint tool is frozen and deprecatde according to the upstream repository: https://github.com/golang/lint

NOTE: Golint is golang/go#38968. There's no drop-in replacement for it, but tools such as Staticcheck and go vet should be used instead.

CI and automation are using golangci-lint and enable staticcheck which is mentioned as a valid replacement.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool
• I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

• How are we going to support this in production?
• How are we going to measure its adoption?
• How are we going to debug this?
• What are the metrics I should take care of?
• ...

[mergify]

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

[elasticmachine]

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

[pchila]

Just a small comment/question on the leftover golang/x/lint entries in go.sum, looks good otherwise

[pchila]

I was expecting for all the others golang.org/x/lint entries to disappear as well as it doesn't seem like we have an indirect dependency according to go.mod. Is this something that would get cleaned up with a mage clean && go mod tidy or we have those entries for some other reason ?

[kruskall]

nope, they are still there even after go mod tidy.

They are still part of the full graph (can be seen with go mod graph) so module pruning isn't leaving them out completely :(

[ycombinator]

++, to elaborate a bit, that's because there are still indirect dependencies on all these various versions of golang.org/x/lint. You can see them if you run go mod graph | grep ' golang.org/x/lint'. This article, particularly Listing 8, explains why older versions of a dependency might still hang around in go.sum.