Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace k8s.io/utils with native package #5236

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

kruskall
Copy link
Member

What does this PR do?

replace k8s.io/utils slices package with stdlib slices package.

Why is it important?

drop one direct dependency

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

replace k8s.io/utils slices package with stdlib slices package.
@kruskall kruskall requested a review from a team as a code owner July 31, 2024 19:29
Copy link
Contributor

mergify bot commented Jul 31, 2024

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@kruskall kruskall added enhancement New feature or request skip-changelog labels Jul 31, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@kruskall kruskall enabled auto-merge (squash) July 31, 2024 21:26
@kruskall kruskall merged commit 32ed849 into elastic:main Jul 31, 2024
13 checks passed
@kruskall kruskall deleted the drop/k8s-utils branch July 31, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants