Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #5270) Increase watcher in upgrade tests to timeout after 10m #5407

Closed
wants to merge 5 commits into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 3, 2024

What does this PR do?

Increase the timeout we wait for the watcher to stop to 10m from 1m.

Why is it important?

7.17.23 has a regression where it will upgrade an 8.x release then roll back after a few minutes.
The expected fix is elastic/beats#40452 which will affect 7.17.24.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues


This is an automatic backport of pull request #5270 done by [Mergify](https://mergify.com).

Increase watcher in upgrade tests to timeout after 10m to catch any regressions for the agent upgrade watcher.

(cherry picked from commit 6b591eb)

# Conflicts:
#	.agent-versions.json
@mergify mergify bot requested a review from a team as a code owner September 3, 2024 14:13
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Sep 3, 2024
@mergify mergify bot requested review from blakerouse and michel-laterman and removed request for a team September 3, 2024 14:13
Copy link
Contributor Author

mergify bot commented Sep 3, 2024

Cherry-pick of 6b591eb has failed:

On branch mergify/bp/8.15/pr-5270
Your branch is up to date with 'origin/8.15'.

You are currently cherry-picking commit 6b591eb4f0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   testing/upgradetest/upgrader.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .agent-versions.json

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@AndersonQ AndersonQ requested review from AndersonQ and removed request for blakerouse September 3, 2024 15:09
@AndersonQ AndersonQ removed the conflicts There is a conflict in the backported pull request label Sep 3, 2024
@AndersonQ
Copy link
Member

it should be done by our automation: #5411

@AndersonQ AndersonQ closed this Sep 4, 2024
@mergify mergify bot deleted the mergify/bp/8.15/pr-5270 branch September 4, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants