Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15](backport #5367) updatecli: automate the Ironbank bumps #5425

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 4, 2024

What does this PR do?

Enable updatecli policies to bump the Ironbank versions automatically, then #3787 won't be manually created.

Those policies can be found in https://github.com/elastic/oblt-updatecli-policies/tree/main/updatecli/policies/ (NOTE: This is a private repository only accessible by Elastic employees)

Additional changes

Why is it important?

One less thing to be worried about.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

  1. Install updatecli
  2. Diff
$ updatecli compose diff --experimental

**Dry Run enabled**

"dev-tools/packaging/templates/ironbank/hardening_manifest.yaml.tmpl" updated with [dry run] content "BASE_TAG: \"9.4\""

--- dev-tools/packaging/templates/ironbank/hardening_manifest.yaml.tmpl
+++ dev-tools/packaging/templates/ironbank/hardening_manifest.yaml.tmpl
@@ -14,7 +14,7 @@
 # Build args passed to Dockerfile ARGs
 args:
   BASE_IMAGE: "redhat/ubi/ubi9"
-  BASE_TAG: "9.3"
+  BASE_TAG: "9.4"
   ELASTIC_STACK: "{{ beat_version }}"
   ELASTIC_PRODUCT: "elastic-agent"

...
⚠ deps: Bump ironbank version:
	Source:
		✔ [ubi_version] Get ubi version from https://repo1.dso.mil/dsop/redhat/ubi/9.x/ubi9
	Target:
		✔ [dockerfile_ironbank] deps(ironbank): Bump ubi version to 9.4
		⚠ [hardening_manifest_ironbank.yaml] deps(ironbank): Bump ubi version to 9.4
  1. Create Pull Request
$ GITHUB_REPOSITORY=elastic/elastic-agent GITHUB_ACTOR=v1v GITHUB_TOKEN=$(gh auth token) updatecli compose apply --experimental
...
Existing GitHub pull request found: https://github.com/elastic/elastic-agent/pull/5423

UDASH - EXPERIMENTAL
=====================

Skipping as no Udash configuration file found at /Users/vmartinez/Library/Application Support/updatecli/udash.json

=============================

SUMMARY:

✔ deps(updatecli): bump all policies:

⚠ deps: Bump ironbank version:
	Source:
		✔ [ubi_version] Get ubi version from https://repo1.dso.mil/dsop/redhat/ubi/9.x/ubi9
	Target:
		✔ [dockerfile_ironbank] deps(ironbank): Bump ubi version to 9.4
		⚠ [hardening_manifest_ironbank.yaml] deps(ironbank): Bump ubi version to 9.4

Related issues

See elastic/apm-server#13934

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #5367 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 4, 2024 17:23
@mergify mergify bot added the backport label Sep 4, 2024
@mergify mergify bot requested review from michel-laterman and swiatekm and removed request for a team September 4, 2024 17:23
@mergify mergify bot assigned v1v Sep 4, 2024
@v1v
Copy link
Member

v1v commented Sep 4, 2024

unrequired, backports are not needed in this case

@v1v v1v closed this Sep 4, 2024
@mergify mergify bot deleted the mergify/bp/8.15/pr-5367 branch September 4, 2024 17:39
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant