[8.x](backport #6495) [helm] add kube-state-metric subchart dependency #6534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: add ksm subchart dependency * feat: refactor elastic-agent chart to utilise ksm subchart * feat: add new ksm examples * fix: typos * feat: remove charts directory * fix: reintroduce Chart.lock (cherry picked from commit edd342a) # Conflicts: # deploy/helm/elastic-agent/Chart.yaml # deploy/helm/elastic-agent/examples/eck/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/kubernetes-default/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/kubernetes-hints-autodiscover/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/multiple-integrations/rendered/manifest.yaml # deploy/helm/elastic-agent/examples/user-service-account/rendered/manifest.yaml
mergify
bot
requested review from
michalpristas and
swiatekm
and removed request for
a team
mergify
bot
added
backport
conflicts
|
Cherry-pick of edd342a has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
pkoutsovasilis
approved these changes
Jan 17, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactors the Elastic Agent Helm chart to include the
kube-state-metrics(KSM) chart as a subchart dependency. The changes enable users to seamlessly deploy KSM alongside the Elastic Agent for all different deployment options, improving the out-of-the-box experience for Kubernetes monitoring.Key changes include:
kube-state-metrics.enabled) and deploying Elastic Agent as a sidecar container to the former (kubernetes.state.agentAsSidecar.enabled)values.schema.jsonhas been updated to prevent such configurationThis PR consists of 3 commits:
since a019dbf, which is the main change of this PR, is +529 additions -1268 deletions I deem that this PR complies with the team PR policies but happy to try to split it up in smaller chunks if it doesn't 🙂
Why is it important?
This PR is important because it enhances the Elastic Agent Helm chart to simplify the deployment and management of Kubernetes monitoring. By including
kube-state-metricsas a subchart dependency, the PR significantly reduces user friction and ensures better alignment with Kubernetes integration requirements.The refactoring also:
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
This PR introduces a new default behavior that includes the
kube-state-metricschart as a dependency. By default:kube-state-metrics.enabled=falseto opt out of deployingkubernetes.state.agentAsSidecar.enabled=true.For users upgrading existing installations,
ksmShardedpreset is gonna be uninstalled and their kube-state-metrics related flow will follow the logic aboveHow to test this PR locally
Related issues
This is an automatic backport of pull request #6495 done by [Mergify](https://mergify.com).