Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] [Integration tests] Enable ARM tests for common test groups #6902

Merged
merged 8 commits into from
Feb 28, 2025
Merged

[CI] [Integration tests] Enable ARM tests for common test groups #6902

merged 8 commits into from
Feb 28, 2025

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Feb 17, 2025

What does this PR do?

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request skip-changelog Team:Ingest-EngProd backport-active-all Automated backport with mergify to all the active branches labels Feb 17, 2025
@pazone pazone requested a review from a team as a code owner February 17, 2025 13:46
@mergify mergify bot assigned pazone Feb 17, 2025
dliappis
dliappis reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to see these arm:sudo tests running as part of the PR. Is there a way to see if they run (successfully)?

@pazone
Copy link
Contributor Author

pazone commented Feb 21, 2025

ARM tests are passing, however the PR is blocked by a knows flaky test: #6924

@kaanyalti
Copy link
Contributor

This PR #6897 is merged, if you can rebase, the error that you're seeing in the integration tests should be resolved.

@pazone
Copy link
Contributor Author

pazone commented Feb 27, 2025

buildkite test this

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ev1yehor
ev1yehor approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@ev1yehor ev1yehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis self-requested a review February 28, 2025 15:51
dliappis
dliappis reviewed Feb 28, 2025
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I now see the three arm:sudo tests (upgrade-flavor/standalone-upgrade/fleet) . The fleet one of them seems to be having a flaky test testing/integration TestSetLogLevelFleetManaged is this flakiness tracked somewhere?

@pazone
Copy link
Contributor Author

pazone commented Feb 28, 2025

Thanks! I now see the three arm:sudo tests (upgrade-flavor/standalone-upgrade/fleet) . The fleet one of them seems to be having a flaky test testing/integration TestSetLogLevelFleetManaged is this flakiness tracked somewhere?

Yes, here is the issue for the flaky test

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @pazone

@pazone pazone merged commit 694cec8 into main Feb 28, 2025
14 checks passed
@pazone pazone deleted the ci_it_enable_arm branch February 28, 2025 21:34
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
@pazone @mergify
[CI] [Integration tests] Enable ARM tests for common test groups (#6902)
02ca6ef 
* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
@pazone @mergify
[CI] [Integration tests] Enable ARM tests for common test groups (#6902)
9918f90 
* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)
This was referenced Feb 28, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
@pazone @mergify
[CI] [Integration tests] Enable ARM tests for common test groups (#6902)
e727e60 
* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)
@mergify mergify bot mentioned this pull request Feb 28, 2025
Merged
8 tasks
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
@pazone @mergify
[CI] [Integration tests] Enable ARM tests for common test groups (#6902)
dfe90fc 
* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)
mergify bot pushed a commit that referenced this pull request Feb 28, 2025
@pazone @mergify
[CI] [Integration tests] Enable ARM tests for common test groups (#6902)
fd07ccc 
* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)
This was referenced Feb 28, 2025
Merged
Merged
pazone added a commit that referenced this pull request Mar 3, 2025
@mergify @pazone
[CI] [Integration tests] Enable ARM tests for common test groups (#6902…
5ea3954 
…) (#7117)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request Mar 3, 2025
@mergify @pazone
[CI] [Integration tests] Enable ARM tests for common test groups (#6902…
b9e57d1 
…) (#7116)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request Mar 3, 2025
@mergify @pazone
[CI] [Integration tests] Enable ARM tests for common test groups (#6902…
45fe7f3 
…) (#7119)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request Mar 3, 2025
@mergify @pazone
[CI] [Integration tests] Enable ARM tests for common test groups (#6902…
f5311cb 
…) (#7118)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
pazone added a commit that referenced this pull request Mar 3, 2025
@mergify @pazone
[CI] [Integration tests] Enable ARM tests for common test groups (#6902…
d3d4eb7 
…) (#7115)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths

(cherry picked from commit 694cec8)

Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>
kaanyalti pushed a commit to kaanyalti/elastic-agent that referenced this pull request Mar 3, 2025
@pazone @kaanyalti
[CI] [Integration tests] Enable ARM tests for common test groups (ela…
86be45e 
…stic#6902)

* [CI] [Integration tests] Enable ARM tests for common test groups

* Added a comment

* [CI] Added .buildkite/bk.integration.pipeline.yml to extended trigger paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis left review comments

@blakerouse blakerouse blakerouse approved these changes

@oakrizan oakrizan oakrizan approved these changes

@ev1yehor ev1yehor ev1yehor approved these changes

@rdner rdner Awaiting requested review from rdner

@pchila pchila Awaiting requested review from pchila

Assignees

@pazone pazone

Labels
backport-active-all Automated backport with mergify to all the active branches enhancement New feature or request skip-changelog Team:Ingest-EngProd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pazone @kaanyalti @elasticmachine @dliappis @blakerouse @oakrizan @ev1yehor