Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http response status checks to TestSetLogLevelFleetManaged #7049

Merged
merged 2 commits into from
Feb 28, 2025
Merged

Add http response status checks to TestSetLogLevelFleetManaged #7049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fd0232
Add http response status checks to TestSetLogLevelFleetManaged
pchila Feb 26, 2025
dda4756
Merge branch 'main' into add-fleet-response-checks-to-TestSetLogLevel…
blakerouse Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 29 additions & 16 deletions testing/integration/log_level_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (
"fmt"
"io"
"net/http"
"net/http/httputil"
"strings"
"testing"
"text/template"
Expand Down Expand Up @@ -245,19 +246,27 @@ func updateAgentLogLevel(ctx context.Context, t *testing.T, kibanaClient *kibana
}

err = updateLogLevelTemplate.Execute(buf, templateData)
if err != nil {
return fmt.Errorf("rendering updateLogLevelTemplate: %w", err)
}

t.Logf("Updating agent-specific log level to %q", logLevel)
_, err = kibanaClient.SendWithContext(ctx, http.MethodPost, "/api/fleet/agents/"+agentID+"/actions", nil, nil, buf)
resp, err := kibanaClient.SendWithContext(ctx, http.MethodPost, "/api/fleet/agents/"+agentID+"/actions", nil, nil, buf)
if err != nil {
return fmt.Errorf("error executing fleet request: %w", err)
}

// The log below is a bit spammy but it can be useful for debugging
//respDump, err := httputil.DumpResponse(fleetResp, true)
//if err != nil {
// t.Logf("Error dumping Fleet response to updating agent-specific log level: %v", err)
//} else {
// t.Logf("Fleet response to updating agent-specific log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
//}
if resp.StatusCode != http.StatusOK {
t.Logf("error updating agent-specific log level to %q", logLevel)
// The log below is a bit spammy but it can be useful for debugging
respDump, err := httputil.DumpResponse(resp, true)
if err != nil {
t.Logf("Error dumping Fleet response to updating agent-specific log level: %v", err)
} else {
t.Logf("Fleet response to updating agent-specific log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
}
return fmt.Errorf("error updating agent-specific log level to %q: fleet response status code: %d", logLevel, resp.StatusCode)
}

return nil
}
Expand Down Expand Up @@ -293,19 +302,23 @@ func updatePolicyLogLevel(ctx context.Context, t *testing.T, kibanaClient *kiban
return fmt.Errorf("error rendering policy update template: %w", err)
}

_, err = kibanaClient.SendWithContext(ctx, http.MethodPut, "/api/fleet/agent_policies/"+policy.ID, nil, nil, buf)
resp, err := kibanaClient.SendWithContext(ctx, http.MethodPut, "/api/fleet/agent_policies/"+policy.ID, nil, nil, buf)

if err != nil {
return fmt.Errorf("error executing fleet request: %w", err)
}

// The log below is a bit spammy but it can be useful for debugging
//respDump, err := httputil.DumpResponse(fleetResp, true)
//if err != nil {
// t.Logf("Error dumping Fleet response to updating policy log level: %v", err)
//} else {
// t.Logf("Fleet response to updating policy log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
//}
if resp.StatusCode != http.StatusOK {
t.Logf("error updating policy log level to %q", newPolicyLogLevel)
// The log below is a bit spammy but it can be useful for debugging
respDump, err := httputil.DumpResponse(resp, true)
if err != nil {
t.Logf("Error dumping Fleet response to updating policy log level: %v", err)
} else {
t.Logf("Fleet response to updating policy log level:\n----- BEGIN RESPONSE DUMP -----\n%s\n----- END RESPONSE DUMP -----\n", string(respDump))
}
return fmt.Errorf("error updating policy log level to %q: fleet response status code: %d", newPolicyLogLevel, resp.StatusCode)
}

return nil
}
Expand Down
Loading