-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/pkg/agent/cmd: remove redundant addCommandIfNotNil func #7502
base: main
Are you sure you want to change the base?
Conversation
None of the subcommand construction functions return a nil *cobra.Command, althought this was apparently the case in the past. So remove the wrapper func and its tests.
This pull request does not have a backport label. Could you fix it @efd6? 🙏
|
|
Not sure what backport policy you want with this. |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
💚 Build Succeeded
cc @efd6 |
I think we can backport this to 8.x but would like @ebeahan's opinion here (or someone from his team). |
What does this PR do?
None of the subcommand construction functions return a nil *cobra.Command, althought this was apparently the case in the past. So remove the wrapper func and its tests.
Why is it important?
Reduce complexity and bugspace.
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself