Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates trained model tests #140

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Updates trained model tests #140

merged 1 commit into from
Oct 11, 2024

Conversation

picandocodigo
Copy link
Member

Infer trained model works on Serverless as long as we use the latest URL: /_ml/trained_models/{model_id}/deployment/_infer is deprecated. Use /_ml/trained_models/{model_id}/_infer instead

This adds a test for the API in Serverless.

Infer trained model works on Serverless as long as we use the latest URL:
`/_ml/trained_models/{model_id}/deployment/_infer` is deprecated.
Use `/_ml/trained_models/{model_id}/_infer instead`

This adds a test for the API in Serverless.
@picandocodigo picandocodigo requested a review from a team October 11, 2024 08:05
picandocodigo added a commit to elastic/elasticsearch-serverless-ruby that referenced this pull request Oct 11, 2024
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The Python generator correctly calls the non-deprecated API.

@picandocodigo picandocodigo merged commit d10df56 into main Oct 11, 2024
3 checks passed
@picandocodigo picandocodigo deleted the trained_model branch October 11, 2024 12:47
picandocodigo added a commit to elastic/elasticsearch-serverless-ruby that referenced this pull request Oct 11, 2024
@pquentin
Copy link
Member

However, this breaks the Python tests because the trained model is not ready/deployed:

ConflictError(409, 'status_exception', 'Trained model deployment [test_model] is not allocated to any nodes')

Are you doing something specific in Ruby to handle this?

@picandocodigo
Copy link
Member Author

I am doing delayed retries (not for 409 though) as I commented in #83. I think that's the only specific thing I'm doing for errors, but I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants