Adds migrate tests #224
Merged
Adds migrate tests #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picandocodigo
requested review from
pquentin,
JoshMock,
ezimuel and
miguelgrinberg
JoshMock
approved these changes
Feb 21, 2025
tests/migration/20_reindex.yml
Outdated
| "index": "test-reindex-datastream" | ||
| } | ||
| } | ||
| - match: { acknowledged: true } |
There was a problem hiding this comment.
what's the difference between match: { acknowledged: true } and is_true: acknowledged? You're using both in this file.
There was a problem hiding this comment.
They're the same, but I updated it to use is_true for consistency 👍
picandocodigo
force-pushed
the
migrate_tests
branch
from
cf61ae6 to
f0a7e97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.