Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use date string for start date #38

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Use date string for start date #38

merged 1 commit into from
Feb 29, 2024

Conversation

JoshMock
Copy link
Member

JS doesn't cast 0 to a date, so this test was failing. Explicitly setting it to the equivalent date string makes it pass.

@JoshMock JoshMock merged commit 633d07a into main Feb 29, 2024
1 check passed
@JoshMock JoshMock deleted the fix-test-start-date branch February 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@picandocodigo picandocodigo Awaiting requested review from picandocodigo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshMock @pquentin