ESQL: Rename Validatable iface to PostLogicalOptimizationVerificationAware #119985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename interface to align it with the similar post-analysis interfaces.
bpintea
added
>refactoring
auto-backport
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
6 tasks
costin
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
LGTM. The only comment is around naming - PostLogicalOptimizationVerificationAware is very explicit but also long; I wonder if we should drop the Logical prefix and assume it's explicit since I don't expect a PostPhysicalOptimizationVerificationAware interface any time soon.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename interface to align it with the similar post-analysis interfaces.
Related #119798.