-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] MacOS 13 Unit tests #3253
Merged
Merged
[CI] MacOS 13 Unit tests #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
approved these changes
Feb 5, 2024
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
|
v1v
reviewed
Mar 5, 2025
@@ -31,6 +31,13 @@ steps: | |||
cpu: "8" | |||
memory: "4G" | |||
|
|||
- label: ":building_construction: Run local build: MacOS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pazone, what's the reason we build this? IIUC, the tests step does not use these artifacts? Or am i seeing this wrongly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
We need to ensure that we can always reliably run tests locally. For this, we should have a CI pipeline that runs tests on OSX and detects regressions there.
How does this PR solve the problem?
Makes buildkite run unit tests on each PR and push to
main
.Added steps:
Made unit test artifacts and sonarqube scan ready for cross-platform builds
Relates #2765