Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] MacOS 13 Unit tests #3253

Merged
merged 9 commits into from
Feb 8, 2024
Merged

[CI] MacOS 13 Unit tests #3253

merged 9 commits into from
Feb 8, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Feb 5, 2024

What is the problem this PR solves?

We need to ensure that we can always reliably run tests locally. For this, we should have a CI pipeline that runs tests on OSX and detects regressions there.

How does this PR solve the problem?

Makes buildkite run unit tests on each PR and push to main.

Added steps:

  • Run local build: MacOS
  • Run unit tests: MacOS 13

Made unit test artifacts and sonarqube scan ready for cross-platform builds

Relates #2765

@pazone pazone added the enhancement New feature or request label Feb 5, 2024
@pazone pazone linked an issue Feb 5, 2024 that may be closed by this pull request
@pazone pazone marked this pull request as ready for review February 5, 2024 12:03
@pazone pazone requested a review from a team as a code owner February 5, 2024 12:03
@pazone pazone requested a review from jsoriano February 5, 2024 12:03
@pazone pazone mentioned this pull request Feb 5, 2024
pazone and others added 2 commits February 8, 2024 16:41
Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
@pazone pazone merged commit d2dcf16 into main Feb 8, 2024
@pazone pazone deleted the ci_macos_unit_tests branch February 8, 2024 15:42
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@@ -31,6 +31,13 @@ steps:
cpu: "8"
memory: "4G"

- label: ":building_construction: Run local build: MacOS"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pazone, what's the reason we build this? IIUC, the tests step does not use these artifacts? Or am i seeing this wrongly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI pipeline for OSX
3 participants