Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fleet-server.reference.yml indentation #3260

Merged
merged 3 commits into from
Feb 9, 2024
Merged

Fix fleet-server.reference.yml indentation #3260

merged 3 commits into from
Feb 9, 2024

Conversation

pierrehilbert
Copy link
Contributor

What is the problem this PR solves?

Looking at the fleet-server.reference.yml, I'm under the impression the indentation is not correct.

How does this PR solve the problem?

Setting the correct indentation to avoid confusion.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@pierrehilbert pierrehilbert added Feature:fleet-server Team:Fleet Label for the Fleet team labels Feb 7, 2024
@pierrehilbert pierrehilbert requested a review from a team as a code owner February 7, 2024 21:47
michel-laterman
michel-laterman approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@pierrehilbert pierrehilbert enabled auto-merge (squash) February 9, 2024 14:19
@pierrehilbert pierrehilbert added the backport-v8.12.0 Automated backport with mergify label Feb 9, 2024
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@pierrehilbert pierrehilbert merged commit f58c107 into main Feb 9, 2024
@pierrehilbert pierrehilbert deleted the reference-indentation branch February 9, 2024 16:10
mergify bot pushed a commit that referenced this pull request Feb 9, 2024
@pierrehilbert @mergify
Fix fleet-server.reference.yml indentation (#3260)
4716ef5 
(cherry picked from commit f58c107)

# Conflicts:
#	fleet-server.reference.yml
@mergify mergify bot mentioned this pull request Feb 9, 2024
Merged
pierrehilbert added a commit that referenced this pull request Feb 12, 2024
@mergify @pierrehilbert
[8.12](backport #3260) Fix fleet-server.reference.yml indentation (#3265
027670d 
)

* Fix fleet-server.reference.yml indentation (#3260)

(cherry picked from commit f58c107)

# Conflicts:
#	fleet-server.reference.yml

* Update fleet-server.reference.yml

---------

Co-authored-by: Pierre HILBERT <pierre.hilbert@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michel-laterman michel-laterman michel-laterman approved these changes

Assignees
No one assigned
Labels
backport-v8.12.0 Automated backport with mergify Feature:fleet-server Team:Fleet Label for the Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierrehilbert @michel-laterman