-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
return 429 error if ES api key auth returned 429 #3278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested myself, but change makes sense, thanks!
Would it be possible to add a test for this?
I didn't see existing unit tests on this, I'll try to add. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding tests 👍
buildkite test this |
buildkite, test this |
buildkite test this |
@juliaElastic, Should we backport this to 8.13? |
|
What is the problem this PR solves?
Misleading 401 unauthorized response when ES API key auth returns 429 error.
How does this PR solve the problem?
Return 429 from Fleet Server API if the root cause is ES auth 429 error.
How to test this PR locally
Tested by running a scale test with a custom image with changes from this pr: https://buildkite.com/elastic/observability-perf/builds/2421#018da31f-8f18-43c5-aac0-5d559f0152cb
Errors show up as 429:

Design Checklist
Checklist
./changelog/fragments
using the changelog toolRelated issues