Use fleet-server binary version for cloude2e images #3314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps.
michel-laterman
added
backport-v8.12.0
michel-laterman
commented
Feb 23, 2024
| @@ -286,7 +286,7 @@ release-manager-release: ## - Builds a snapshot release. The Go version defined | |||
| ## get-version : Get the Fleet server version | |||
| .PHONY: get-version | |||
| get-version: | |||
| @echo $(DEFAULT_VERSION) | |||
| @echo $(VERSION) | |||
There was a problem hiding this comment.
$VERSION differs from $DEFAULT_VERSION as it may include snapshot or other version indicators.
The only other target (besides cloude2e) that uses get-version is the buildkite dra target, which should filter out the snapshot indicator
|
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps. (cherry picked from commit 8f7dcc9)
mergify bot
pushed a commit
that referenced
this pull request
Feb 23, 2024
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps. (cherry picked from commit 8f7dcc9)
michel-laterman
added a commit
that referenced
this pull request
Feb 23, 2024
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps. (cherry picked from commit 8f7dcc9) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
michel-laterman
added a commit
that referenced
this pull request
Feb 23, 2024
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps. (cherry picked from commit 8f7dcc9) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
michel-laterman
added a commit
to michel-laterman/fleet-server
that referenced
this pull request
Mar 4, 2024
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Bumping fleet-server versions causes the cloude2e test to fail
How does this PR solve the problem?
Use the fleet-server binary version with snapshot flag when building the cloude2e test image instead of the stack version so fleet-server builds will not fail on version bumps.