Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix-DRA-curl-command #3789

Merged
merged 3 commits into from
Aug 2, 2024
Merged

Fix-DRA-curl-command #3789

merged 3 commits into from
Aug 2, 2024

Conversation

ev1yehor
Copy link
Contributor

@ev1yehor ev1yehor commented Aug 2, 2024

What is the problem this PR solves?

DRA publishing always skipped due to new token permissions
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

Fix curl command to be available for new PAT generated token
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

@ev1yehor ev1yehor added bug Something isn't working backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.14.0 Automated backport with mergify backport-8.15 Automated backport to the 8.15 branch with mergify labels Aug 2, 2024
@ev1yehor ev1yehor requested a review from a team August 2, 2024 13:37
@ev1yehor ev1yehor self-assigned this Aug 2, 2024
@ev1yehor ev1yehor marked this pull request as ready for review August 2, 2024 13:58
@ev1yehor ev1yehor requested a review from a team as a code owner August 2, 2024 13:58
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Aug 2, 2024
@ev1yehor ev1yehor merged commit a46c709 into main Aug 2, 2024
6 of 7 checks passed
@ev1yehor ev1yehor deleted the Fix-DRA-publishing-always-skipped-due-new-PAT branch August 2, 2024 14:06
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
@ev1yehor @mergify
Fix-DRA-curl-command (#3789)
d4ca2ad 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
@ev1yehor @mergify
Fix-DRA-curl-command (#3789)
725c4ca 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)
mergify bot pushed a commit that referenced this pull request Aug 2, 2024
@ev1yehor @mergify
Fix-DRA-curl-command (#3789)
d4c839d 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)
This was referenced Aug 2, 2024
Merged
Merged
Merged
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

ev1yehor added a commit that referenced this pull request Aug 2, 2024
@mergify @ev1yehor
Fix-DRA-curl-command (#3789) (#3792)
f3008c7 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)

Co-authored-by: ev1yehor <146825775+ev1yehor@users.noreply.github.com>
ev1yehor added a commit that referenced this pull request Aug 2, 2024
@mergify @ev1yehor
Fix-DRA-curl-command (#3789) (#3791)
3b74f18 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)

Co-authored-by: ev1yehor <146825775+ev1yehor@users.noreply.github.com>
ev1yehor added a commit that referenced this pull request Aug 2, 2024
@mergify @ev1yehor
Fix-DRA-curl-command (#3789) (#3790)
fa63c12 
* Fix-DRA-curl-command

* Update pre-command

* Update pre-command

(cherry picked from commit a46c709)

Co-authored-by: ev1yehor <146825775+ev1yehor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@rowlandgeoff rowlandgeoff rowlandgeoff approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

@mrodm mrodm Awaiting requested review from mrodm

Assignees

@ev1yehor ev1yehor

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.15 Automated backport to the 8.15 branch with mergify backport-v8.14.0 Automated backport with mergify bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ev1yehor @pierrehilbert @rowlandgeoff