Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4328) Allow use of version qualifier for staging artifacts #4331

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 17, 2025

What is the problem this PR solves?

This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

How does this PR solve the problem?

  • Support VERSION_QUALIFIER optional env var for prerelease builds
  • Refactor packaging pipeline to allow staging builds from main (that indirectly allow testing this PR too with the additional DRA_BRANCH env var and skip snapshot builds when VERSION_QUALIFIER is present
  • Remove unused VERSION and INFRA_REPO variables.

How to test this PR locally

Using this PR and the pipeline https://buildkite.com/elastic/fleet-server-package-mbp with pull/4328/merge and options:

DRA_BRANCH="main"
VERSION_QUALIFIER="alpha1"

results in a successful 9.0.0-alpha1 artifacts, example: https://buildkite.com/elastic/fleet-server-package-mbp/builds/1526

image

Also a test without VERSION_QUALIFIER https://buildkite.com/elastic/fleet-server-package-mbp/builds/1525 produces the expected artifacts (note that when branch is main, i.e. not when testing using this PR, and there is no version qualifier defined, the staging dra publish is skipped, per design).

Related issues

Closes:


This is an automatic backport of pull request #4328 done by [Mergify](https://mergify.com).

This commits adds support for an optional $VERSION_QUALIFIER env var/build option in the packaging pipeline to allow building prerelease artifacts from staging.

Closes:

- #4325
- https://github.com/elastic/ingest-dev/issues/4859

---------

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
(cherry picked from commit 29c1d88)
@mergify mergify bot requested a review from a team as a code owner January 17, 2025 14:06
@mergify mergify bot added the backport label Jan 17, 2025
@mergify mergify bot assigned pchila Jan 17, 2025
@github-actions github-actions bot added Team:Elastic-Agent Label for the Agent team cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 17, 2025
@pchila pchila enabled auto-merge (squash) January 17, 2025 14:11
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pchila pchila merged commit 1a93453 into 8.x Jan 17, 2025
9 checks passed
@pchila pchila deleted the mergify/bp/8.x/pr-4328 branch January 17, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport cleanup Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant