Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run staging builds on main (unless it's a prerelease) #4337

Conversation

dliappis
Copy link
Contributor

What is the problem this PR solves?

This commit is a follow-up to #4328 and fixes a bug for main where staging main artifacts will be products for every merge commit, thus overriding manual builds using VERSION_QUALIFIER.

Related issues

https://github.com/elastic/ingest-dev/issues/4859

This commit is a follow-up to elastic#4328 and fixes a bug for main where staging main
artifacts will be products for every merge commit, thus overriding manual builds
using VERSION_QUALIFIER.
@dliappis dliappis requested a review from a team as a code owner January 17, 2025 15:09
@dliappis dliappis self-assigned this Jan 17, 2025
Copy link
Contributor

mergify bot commented Jan 17, 2025

This pull request does not have a backport label. Could you fix it @dliappis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 17, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 17, 2025
Copy link
Member

@pchila pchila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis dliappis added backport-8.17 Automated backport with mergify backport-8.16 Automated backport with mergify labels Jan 17, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dliappis
Copy link
Contributor Author

Closing a no needed -- the DRA staging step is skipped in this case.

@dliappis dliappis closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants