Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4344) github-actions(pre-commit): detect merge conflicts and shebangs #4346

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 22, 2025

What does this PR do?

Use pre-commit with a subset of checks and run in the CI always.

Why is it important?

Similarly done at elastic/beats#42377

Help with detecting merge conflicts or shebang issues

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues


This is an automatic backport of pull request #4344 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner January 22, 2025 10:40
@mergify mergify bot added the backport label Jan 22, 2025
@mergify mergify bot requested review from andrzej-stencel and pchila January 22, 2025 10:40
@mergify mergify bot assigned v1v Jan 22, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor Author

mergify bot commented Jan 27, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

1 similar comment
Copy link
Contributor Author

mergify bot commented Feb 3, 2025

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@v1v v1v merged commit a7563ea into 8.x Feb 3, 2025
10 checks passed
@v1v v1v deleted the mergify/bp/8.x/pr-4344 branch February 3, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants