Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(buildkite): exclude files/folders that are not tested in Buildkite #4351

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 23, 2025

What is the problem this PR solves?

Run faster builds and avoid waste of CI cycles.

I decided to support the whole .github folder since some other files such as CODEOWNERS or .dependaot.yml and the rest are not actually used by Buildkite.

I took some of the files that we skipped in elastic/elastic-agent#4836. I don't know the reason it was not configured in this repository, too, but I think it's the same case.

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues

Relates elastic/beats#42404

@v1v v1v requested a review from a team as a code owner January 23, 2025 10:55
@v1v v1v self-assigned this Jan 23, 2025
@v1v v1v requested a review from a team January 23, 2025 10:55
Copy link
Contributor

mergify bot commented Jan 23, 2025

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 23, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 23, 2025
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

@rowlandgeoff rowlandgeoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@v1v v1v enabled auto-merge (squash) January 23, 2025 18:02
@v1v v1v merged commit 59522fe into elastic:main Jan 23, 2025
10 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
pkoutsovasilis pushed a commit that referenced this pull request Jan 23, 2025
…#4351) (#4352)

(cherry picked from commit 59522fe)

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants