Change CA generation in tests to avoid using SHA1 #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
Team:Elastic-Agent-Control-Plane
|
blakerouse
approved these changes
Jan 30, 2025
kruskall
reviewed
Jan 30, 2025
| switch publicKey := pub.(type) { | ||
| case *rsa.PublicKey: | ||
| publicKeyBytes = x509.MarshalPKCS1PublicKey(publicKey) | ||
| case *ecdsa.PublicKey: |
There was a problem hiding this comment.
suggestion: I think we can avoid this case since the key is always an rsa key. WDYT ?
There was a problem hiding this comment.
I don' think there's a downside to keeping both; this is just to fix test code
mergify bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
(cherry picked from commit 8909668)
michel-laterman
added a commit
that referenced
this pull request
Feb 10, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
(cherry picked from commit 8909668)
2 tasks
michel-laterman
added a commit
that referenced
this pull request
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Tests ran with
GODEBUG=fips140=onlywill panic due to CA SubjectKeyId generation using SHA1 by default.How does this PR solve the problem?
Populate SubjectKeyId with value generated by other algorithm; copied implementation from elastic/elastic-agent-libs#263
How to test this PR locally
GODEBUG=fips140=only gotip test ./...Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragmentsusing the changelog tool