Add BUILDKITE_ANALYTICS_TOKEN in fips-e2e-test step #4544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
requested review from
dliappis,
pazone,
pkoutsovasilis and
michel-laterman
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
pazone
approved these changes
Mar 5, 2025
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
v1v
approved these changes
Mar 5, 2025
|
jlind23
approved these changes
Mar 5, 2025
pkoutsovasilis
approved these changes
Mar 5, 2025
v1v
added
backport-8.x
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
(cherry picked from commit 2c04d3d) # Conflicts: # .buildkite/hooks/pre-command
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
(cherry picked from commit 2c04d3d)
This was referenced Mar 5, 2025
|
Let's backport it, even though it's only for |
pchila
added a commit
that referenced
this pull request
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Set BUILDKITE_ANALYTICS_TOKEN for FIPS E2E test step. Without this env var FIPS E2E step will break on CI
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.
How does this PR solve the problem?
Include FIPS E2E test step to the list of steps for which BUILDKITE_ANALYTICS_TOKEN will be set in pre-command hook.
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.
How to test this PR locally
Design Checklist
[ ] I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.[ ] I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.[ ] I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog toolRelated issues