Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18](backport #4542) pbkdf2 settings validation is FIPS compliant #4548

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 5, 2025

What is the problem this PR solves?

User pbkdf2 settings are not validated for FIPS compliance.

How does this PR solve the problem?

Validate pbkdf2 settings.

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
    This is an automatic backport of pull request pbkdf2 settings validation is FIPS compliant #4542 done by Mergify.

Validate pbkdf2 settings are FIPS compliant

(cherry picked from commit 63b6b92)

# Conflicts:
#	internal/pkg/config/pbkdf2.go
@mergify mergify bot requested a review from a team as a code owner March 5, 2025 17:00
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 5, 2025
@mergify mergify bot requested review from kaanyalti and andrzej-stencel March 5, 2025 17:00
Copy link
Contributor Author

mergify bot commented Mar 5, 2025

Cherry-pick of 63b6b92 has failed:

On branch mergify/bp/8.18/pr-4542
Your branch is up to date with 'origin/8.18'.

You are currently cherry-picking commit 63b6b92.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/fragments/1741108238-pbkdf2-settings-is-FIPS-compliant.yaml

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   internal/pkg/config/pbkdf2.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Mar 5, 2025
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube

@michel-laterman michel-laterman merged commit 23f80b1 into 8.18 Mar 6, 2025
8 of 9 checks passed
@michel-laterman michel-laterman deleted the mergify/bp/8.18/pr-4542 branch March 6, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants