Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More relaxed retries in agent tests #4567

Merged
merged 1 commit into from
Mar 11, 2025
Merged

More relaxed retries in agent tests #4567

merged 1 commit into from
Mar 11, 2025

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Mar 11, 2025 •
edited
Loading

Just updating retries in agent tests from 120x100ms to 180x100ms.
120 is on the fence with new default retry strategy

@michalpristas michalpristas added flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Mar 11, 2025
@michalpristas michalpristas self-assigned this Mar 11, 2025
@michalpristas michalpristas requested a review from a team as a code owner March 11, 2025 10:48
@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

swiatekm
swiatekm approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're using the same retry count everywhere now, there's value in putting it in a constant imo.

@michalpristas michalpristas merged commit b1c3e7c into elastic:main Mar 11, 2025
10 checks passed
mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@michalpristas @mergify
more relaxed retries (#4567)
35e1fac 
(cherry picked from commit b1c3e7c)
@mergify mergify bot mentioned this pull request Mar 11, 2025
Merged
michalpristas added a commit that referenced this pull request Mar 12, 2025
@mergify @michalpristas
more relaxed retries (#4567) (#4568)
b9ae4d0 
(cherry picked from commit b1c3e7c)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@swiatekm swiatekm swiatekm approved these changes

@kaanyalti kaanyalti Awaiting requested review from kaanyalti kaanyalti is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels
backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches flaky-test Unstable or unreliable test cases. Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michalpristas @andrzej-stencel @swiatekm