-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DRA FIPS artifacts to package pipeline #4574
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
|
@michel-laterman please do not merge https://github.com/elastic/infra/pull/42160 before this gets merged/backported or you'll block the unified release. The same happened to @pchila |
@michel-laterman could you please test this PR on buildkite to see if all the artifacts are correctly generated? BRANCH="main"
BUILDKITE_PULL_REQUEST="true" ref. |
FIPS DRA attempt: https://buildkite.com/elastic/fleet-server-package-mbp/builds/1739 |
Currently the FIPS dra is failing as the package step uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The FIPS artifact builds are now completing, however it is havin issues authenticating with GCP at the end to upload
.buildkite/scripts/common.sh: line 112: PRIVATE_CI_GCS_CREDENTIALS_SECRET: unbound variable
https://buildkite.com/elastic/fleet-server-package-mbp/builds/1743
My next commit fixed this issue, successful build available: https://buildkite.com/elastic/fleet-server-package-mbp/builds/1744
PLATFORMS="" | ||
PACKAGES="" | ||
if [[ ${PLATFORM_TYPE} == "arm" || ${PLATFORM_TYPE} == "aarch64" ]]; then | ||
PLATFORMS="linux/arm64" | ||
PACKAGES="docker" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually a bit of a mess at the moment.
PACKAGES
is unused by the Makefile.
Also PLATFORMS
is never exported here so it does not get used by the Makefile; both the arm64 and and amd64 instances build all packages.
Should we remove this part entirely, or do we want to restrict the packages each builder should produce?
02cac91
to
6550186
Compare
Thanks a @v1v I changed all our |
|
What is the problem this PR solves?
Provide FIPS dra artifacts.
How does this PR solve the problem?
Add
FIPS="true"
env flag to packageing pipeline.Packaging pipline uses microsoft/go instead of golang/go to build DRA artifacts for FIPS.
Change package name from
fleet-server-*-fips
tofleet-server-fips-*
.Design Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry in./changelog/fragments
using the changelog toolRelated issues