Add go1.24 GODEBUG=fips140=only test #4581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michel-laterman
added
Team:Elastic-Agent-Control-Plane
|
swiatekm
approved these changes
Mar 19, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Add a new target that uses GODEBUG=fips140=only to run unit tests. This target should use the FIPS=true flag in order to pass -tags=requirefips. (cherry picked from commit 8e304bd)
mergify bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
Add a new target that uses GODEBUG=fips140=only to run unit tests. This target should use the FIPS=true flag in order to pass -tags=requirefips. (cherry picked from commit 8e304bd)
This was referenced Mar 19, 2025
michel-laterman
added a commit
that referenced
this pull request
Mar 19, 2025
Add a new target that uses GODEBUG=fips140=only to run unit tests. This target should use the FIPS=true flag in order to pass -tags=requirefips. (cherry picked from commit 8e304bd) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
michel-laterman
added a commit
that referenced
this pull request
Mar 20, 2025
* Add go1.24 GODEBUG=fips140=only test (#4581) Add a new target that uses GODEBUG=fips140=only to run unit tests. This target should use the FIPS=true flag in order to pass -tags=requirefips. (cherry picked from commit 8e304bd) * Split 8.x TLS min version tests for FIPS * Fix ES Output TLS tests --------- Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: michel-laterman <michel.laterman@elastic.co>
andrzej-stencel
added a commit
that referenced
this pull request
Mar 24, 2025
* [updatecli] update elastic stack version for testing 9.1.0-80bdca58-SNAPSHOT (#4569) * chore: Update snapshot.yml Made with ❤️️ by updatecli * chore: Update snapshot.yml Made with ❤️️ by updatecli * chore: Update snapshot.yml Made with ❤️️ by updatecli --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): bump github.com/elastic/elastic-agent-libs from 0.18.8 to 0.18.10 (#4565) * build(deps): bump github.com/elastic/elastic-agent-libs Bumps [github.com/elastic/elastic-agent-libs](https://github.com/elastic/elastic-agent-libs) from 0.18.8 to 0.18.10. - [Release notes](https://github.com/elastic/elastic-agent-libs/releases) - [Commits](elastic/elastic-agent-libs@v0.18.8...v0.18.10) --- updated-dependencies: - dependency-name: github.com/elastic/elastic-agent-libs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Post dependabot file modifications --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * chore: Update snapshot.yml (#4588) Made with ❤️️ by updatecli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): bump github.com/elastic/elastic-agent-libs from 0.18.10 to 0.18.11 (#4591) * build(deps): bump github.com/elastic/elastic-agent-libs Bumps [github.com/elastic/elastic-agent-libs](https://github.com/elastic/elastic-agent-libs) from 0.18.10 to 0.18.11. - [Release notes](https://github.com/elastic/elastic-agent-libs/releases) - [Commits](elastic/elastic-agent-libs@v0.18.10...v0.18.11) --- updated-dependencies: - dependency-name: github.com/elastic/elastic-agent-libs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Post dependabot file modifications --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * chore: Update snapshot.yml (#4596) Made with ❤️️ by updatecli Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * build(deps): bump the elastic-apm group with 6 updates (#4590) * build(deps): bump the elastic-apm group with 6 updates Bumps the elastic-apm group with 6 updates: | Package | From | To | | --- | --- | --- | | [go.elastic.co/apm/module/apmchiv5/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | | [go.elastic.co/apm/module/apmelasticsearch/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | | [go.elastic.co/apm/module/apmhttp/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | | [go.elastic.co/apm/module/apmprometheus/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | | [go.elastic.co/apm/module/apmzerolog/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | | [go.elastic.co/apm/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` | Updates `go.elastic.co/apm/module/apmchiv5/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) Updates `go.elastic.co/apm/module/apmelasticsearch/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) Updates `go.elastic.co/apm/module/apmhttp/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) Updates `go.elastic.co/apm/module/apmprometheus/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) Updates `go.elastic.co/apm/module/apmzerolog/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) Updates `go.elastic.co/apm/v2` from 2.6.3 to 2.7.0 - [Release notes](https://github.com/elastic/apm-agent-go/releases) - [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc) - [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0) --- updated-dependencies: - dependency-name: go.elastic.co/apm/module/apmchiv5/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm - dependency-name: go.elastic.co/apm/module/apmelasticsearch/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm - dependency-name: go.elastic.co/apm/module/apmhttp/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm - dependency-name: go.elastic.co/apm/module/apmprometheus/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm - dependency-name: go.elastic.co/apm/module/apmzerolog/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm - dependency-name: go.elastic.co/apm/v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: elastic-apm ... Signed-off-by: dependabot[bot] <support@github.com> * Post dependabot file modifications --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Remove WithUsrPwd (#4600) * build(deps): bump github.com/containerd/containerd in /testing (#4599) Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.15 to 1.7.27. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.7.15...v1.7.27) --- updated-dependencies: - dependency-name: github.com/containerd/containerd dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add go1.24 GODEBUG=fips140=only test (#4581) Add a new target that uses GODEBUG=fips140=only to run unit tests. This target should use the FIPS=true flag in order to pass -tags=requirefips. * [Automation] Bump Golang version to 1.24.1 (#4611) * chore: Update .go-version Made with ❤️️ by updatecli * chore: Update .golangci.yml Made with ❤️️ by updatecli --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update golangci-lint.yml (#4615) Pinning action to a full length commit SHA [see](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions) * build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.9 to 0.11.10 (#4621) * build(deps): bump github.com/elastic/elastic-agent-system-metrics Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.9 to 0.11.10. - [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases) - [Commits](elastic/elastic-agent-system-metrics@v0.11.9...v0.11.10) --- updated-dependencies: - dependency-name: github.com/elastic/elastic-agent-system-metrics dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Post dependabot file modifications --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Blake Rouse <blake.rouse@elastic.co> Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com> Co-authored-by: Paul McCann <paul.mccann@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR solves?
Validate FIPS compliance by using go 1.24's fips features.
How does this PR solve the problem?
Add a new target that uses GODEBUG=fips140=only to run unit tests.
This target should use the
FIPS=trueflag in order to pass-tags=requirefips.Note that this target assumes golang/go and NOT microsoft/go.
In order to use microsoft/go to run these test we would need to install in the environment, and have a FIPS enabled OpenSSL on the system.
How to test this PR locally
FIPS=true make test-unit-fipsDesign Checklist
I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry in./changelog/fragmentsusing the changelog tool