Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WithUsrPwd #4600

Merged
merged 1 commit into from
Mar 18, 2025
Merged

Remove WithUsrPwd #4600

merged 1 commit into from
Mar 18, 2025

Conversation

blakerouse
Copy link
Contributor

What is the problem this PR solves?

Removes the es.WithUsrPwd to ensure that it is not used outside of tests.

How does this PR solve the problem?

Prevents mis-use in production code.

@blakerouse blakerouse added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 18, 2025
@blakerouse blakerouse self-assigned this Mar 18, 2025
@blakerouse blakerouse requested a review from a team as a code owner March 18, 2025 02:36
Copy link

@blakerouse blakerouse merged commit 79b9795 into elastic:main Mar 18, 2025
10 checks passed
@blakerouse blakerouse deleted the remove-es-WithUsrPwd branch March 18, 2025 15:05
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit 79b9795)
mergify bot pushed a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit 79b9795)
blakerouse added a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit 79b9795)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
blakerouse added a commit that referenced this pull request Mar 18, 2025
(cherry picked from commit 79b9795)

Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
andrzej-stencel added a commit that referenced this pull request Mar 24, 2025
* [updatecli] update elastic stack version for testing 9.1.0-80bdca58-SNAPSHOT (#4569)

* chore: Update snapshot.yml

Made with ❤️️ by updatecli

* chore: Update snapshot.yml

Made with ❤️️ by updatecli

* chore: Update snapshot.yml

Made with ❤️️ by updatecli

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): bump github.com/elastic/elastic-agent-libs from 0.18.8 to 0.18.10 (#4565)

* build(deps): bump github.com/elastic/elastic-agent-libs

Bumps [github.com/elastic/elastic-agent-libs](https://github.com/elastic/elastic-agent-libs) from 0.18.8 to 0.18.10.
- [Release notes](https://github.com/elastic/elastic-agent-libs/releases)
- [Commits](elastic/elastic-agent-libs@v0.18.8...v0.18.10)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-libs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Post dependabot file modifications

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

* chore: Update snapshot.yml (#4588)

Made with ❤️️ by updatecli

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): bump github.com/elastic/elastic-agent-libs from 0.18.10 to 0.18.11 (#4591)

* build(deps): bump github.com/elastic/elastic-agent-libs

Bumps [github.com/elastic/elastic-agent-libs](https://github.com/elastic/elastic-agent-libs) from 0.18.10 to 0.18.11.
- [Release notes](https://github.com/elastic/elastic-agent-libs/releases)
- [Commits](elastic/elastic-agent-libs@v0.18.10...v0.18.11)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-libs
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Post dependabot file modifications

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

* chore: Update snapshot.yml (#4596)

Made with ❤️️ by updatecli

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* build(deps): bump the elastic-apm group with 6 updates (#4590)

* build(deps): bump the elastic-apm group with 6 updates

Bumps the elastic-apm group with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [go.elastic.co/apm/module/apmchiv5/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |
| [go.elastic.co/apm/module/apmelasticsearch/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |
| [go.elastic.co/apm/module/apmhttp/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |
| [go.elastic.co/apm/module/apmprometheus/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |
| [go.elastic.co/apm/module/apmzerolog/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |
| [go.elastic.co/apm/v2](https://github.com/elastic/apm-agent-go) | `2.6.3` | `2.7.0` |


Updates `go.elastic.co/apm/module/apmchiv5/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

Updates `go.elastic.co/apm/module/apmelasticsearch/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

Updates `go.elastic.co/apm/module/apmhttp/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

Updates `go.elastic.co/apm/module/apmprometheus/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

Updates `go.elastic.co/apm/module/apmzerolog/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

Updates `go.elastic.co/apm/v2` from 2.6.3 to 2.7.0
- [Release notes](https://github.com/elastic/apm-agent-go/releases)
- [Changelog](https://github.com/elastic/apm-agent-go/blob/v2.7.0/CHANGELOG.asciidoc)
- [Commits](elastic/apm-agent-go@v2.6.3...v2.7.0)

---
updated-dependencies:
- dependency-name: go.elastic.co/apm/module/apmchiv5/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
- dependency-name: go.elastic.co/apm/module/apmelasticsearch/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
- dependency-name: go.elastic.co/apm/module/apmhttp/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
- dependency-name: go.elastic.co/apm/module/apmprometheus/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
- dependency-name: go.elastic.co/apm/module/apmzerolog/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
- dependency-name: go.elastic.co/apm/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: elastic-apm
...

Signed-off-by: dependabot[bot] <support@github.com>

* Post dependabot file modifications

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

* Remove WithUsrPwd (#4600)

* build(deps): bump github.com/containerd/containerd in /testing (#4599)

Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.7.15 to 1.7.27.
- [Release notes](https://github.com/containerd/containerd/releases)
- [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
- [Commits](containerd/containerd@v1.7.15...v1.7.27)

---
updated-dependencies:
- dependency-name: github.com/containerd/containerd
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add go1.24 GODEBUG=fips140=only test (#4581)

Add a new target that uses GODEBUG=fips140=only to run unit tests.
This target should use the FIPS=true flag in order to pass -tags=requirefips.

* [Automation] Bump Golang version to 1.24.1 (#4611)

* chore: Update .go-version

Made with ❤️️ by updatecli

* chore: Update .golangci.yml

Made with ❤️️ by updatecli

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update golangci-lint.yml (#4615)

Pinning action to a full length commit SHA [see](https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#using-third-party-actions)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics from 0.11.9 to 0.11.10 (#4621)

* build(deps): bump github.com/elastic/elastic-agent-system-metrics

Bumps [github.com/elastic/elastic-agent-system-metrics](https://github.com/elastic/elastic-agent-system-metrics) from 0.11.9 to 0.11.10.
- [Release notes](https://github.com/elastic/elastic-agent-system-metrics/releases)
- [Commits](elastic/elastic-agent-system-metrics@v0.11.9...v0.11.10)

---
updated-dependencies:
- dependency-name: github.com/elastic/elastic-agent-system-metrics
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

* Post dependabot file modifications

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Blake Rouse <blake.rouse@elastic.co>
Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Co-authored-by: Paul McCann <paul.mccann@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants