[go] upgrade to 1.23

.github/workflows/codeql-analysis.yml

@@ -40,7 +40,7 @@ jobs:
       name: Set up Go
       uses: actions/setup-go@v3
       with:
-        go-version: 1.19
+        go-version: 1.23
     -
       name: Build Harp
       run: |

.github/workflows/go.yml

@@ -26,50 +26,49 @@ concurrency:
   cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
 
 jobs:
-  # Check if there any dirty change for go mod tidy
+  # Check if there are any dirty change for go mod tidy
   go-mod:
     name: "Check go modules declaration"
     runs-on: ubuntu-latest
     steps:
       -
         name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.19
+          go-version: 1.23
       -
         name: Checkout code
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Check go mod and go.sum
         run: |
           go mod tidy -v
           git --no-pager diff go.mod go.sum
           git --no-pager diff --quiet go.mod go.sum
 
-  # Try compile all binaries first
+  # Try to compile all binaries first
   compile-dryrun:
     name: "Compile"
     strategy:
       fail-fast: true
       matrix:
         go-version:
-          - "1.19"
-          - "1.18.10"
+          - "1.23.2"
     runs-on: ubuntu-latest
     needs: [golangci-lint, go-mod]
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
           go-version: ${{ matrix.go-version }}
           check-latest: true
       -
         name: Cache Go modules
-        uses: actions/cache@v3.0.3
+        uses: actions/cache@v4.2.0
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -90,14 +89,14 @@ jobs:
     steps:
       -
         name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.19
+          go-version: 1.23
       -
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Lint code
-        uses: golangci/golangci-lint-action@v3
+        uses: golangci/golangci-lint-action@v6
         with:
           version: latest
           args: --timeout=10m
@@ -109,15 +108,15 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.19
+          go-version: 1.23
       -
         name: Cache Go modules
-        uses: actions/cache@v3.0.3
+        uses: actions/cache@v4.2.0
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -128,9 +127,9 @@ jobs:
         run: go mod download
       -
         name: Setup gotestsum
-        uses: autero1/action-gotestsum@v1.0.0
+        uses: autero1/action-gotestsum@v2.0.0
         with:
-          gotestsum_version: 1.7.0
+          gotestsum_version: 1.12.0
       -
         name: Run tests
         run: gotestsum --format short-verbose ./pkg/...
@@ -142,12 +141,12 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.19
+          go-version: 1.23.2
       -
         name: Cache Go modules
         uses: actions/cache@v3.0.3
@@ -161,9 +160,9 @@ jobs:
         run: go mod download
       -
         name: Setup gotestsum
-        uses: autero1/action-gotestsum@v1.0.0
+        uses: autero1/action-gotestsum@v2.0.0
         with:
-          gotestsum_version: 1.7.0
+          gotestsum_version: 1.12.0
       -
         name: Run tests
         run: gotestsum --format short-verbose ./pkg/...
@@ -175,15 +174,15 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
       -
         name: Install Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v5
         with:
-          go-version: 1.19
+          go-version: 1.23.2
       -
         name: Cache Go modules
-        uses: actions/cache@v3.0.3
+        uses: actions/cache@v4.2.0
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -194,9 +193,9 @@ jobs:
         run: go mod download
       -
         name: Setup gotestsum
-        uses: autero1/action-gotestsum@v1.0.0
+        uses: autero1/action-gotestsum@v2.0.0
         with:
-          gotestsum_version: 1.7.0
+          gotestsum_version: 1.12.0
       -
         name: Run tests
         run: gotestsum --format short-verbose ./pkg/...

.github/workflows/releaser.yml

@@ -26,13 +26,12 @@ jobs:
         run: git fetch --prune --unshallow
       -
         name: Set up Go
-        uses: actions/setup-go@v3
+        uses: actions/setup-go@v4
         with:
-          go-version: '1.19'
-          check-latest: true
+          go-version: '1.23.2'
       -
         name: Cache Go modules
-        uses: actions/cache@v3.0.3
+        uses: actions/cache@v4.2.0
         with:
           path: ~/go/pkg/mod
           key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
@@ -47,7 +46,7 @@ jobs:
           GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}"
       -
         name: Install Cosign
-        uses: sigstore/cosign-installer@v2.3.0
+        uses: sigstore/cosign-installer@v3.7.0
       -
         name: Import Code-Signing Certificates
         uses: Apple-Actions/import-codesign-certs@v1

.golangci.yml

@@ -1,3 +1,11 @@
+issues:
+  exclude-files:
+    - ".*\\.pb\\.go$"
+    - ".*\\.gen\\.go$"
+    - ".*\\_gen\\.go$"
+    - "mock_.*\\.go"
+    - ".*\\.resolvers\\.go$"
+
 run:
   # default concurrency is a available CPU number
   concurrency: 4
@@ -8,13 +16,6 @@ run:
   # include test files or not, default is true
   tests: false
 
-  skip-files:
-    - ".*\\.pb\\.go$"
-    - ".*\\.gen\\.go$"
-    - ".*\\_gen\\.go$"
-    - "mock_.*\\.go"
-    - ".*\\.resolvers\\.go$"
-
   # default is true. Enables skipping of directories:
   #   vendor$, third_party$, testdata$, examples$, Godeps$, builtin$
   skip-dirs-use-default: true
@@ -37,7 +38,7 @@ run:
 output:
   # colored-line-number|line-number|json|tab|checkstyle|code-climate|junit-xml|github-actions
   # default is "colored-line-number"
-  format: colored-line-number
+  formats: colored-line-number
 
   # print lines of code with issue, default is true
   print-issued-lines: true
@@ -142,7 +143,7 @@ linters-settings:
     # [deprecated] comma-separated list of pairs of the form pkg:regex
     # the regex is used to ignore names within pkg. (default "fmt:.*").
     # see https://github.com/kisielk/errcheck#the-deprecated-method for details
-    ignore: fmt:.*,io/ioutil:^Read.*
+    exclude-functions: fmt:.*,io/ioutil:^Read.*
   exhaustive:
     # check switch statements in generated files also
     check-generated: false
@@ -151,8 +152,7 @@ linters-settings:
     # switch
     default-signifies-exhaustive: false
   govet:
-    # report about shadowed variables
-    check-shadowing: true
+    shadow: true
   goimports:
     local: "github.com/elastic"
   golint:
@@ -161,6 +161,9 @@ linters-settings:
     simplify: true
   gocyclo:
     min-complexity: 15
+  gosec:
+    excludes:
+    - G115 # integer overflow conversion
   misspell:
     locale: US
   lll:
@@ -170,7 +173,8 @@ linters-settings:
     # put imports beginning with prefix after 3rd-party packages;
     # only support one prefix
     # if not set, use goimports.local-prefixes
-    local-prefixes: github.com/elastic
+    sections:
+    - prefix(github.com/elastic)
   gocognit:
     # minimal code complexity to report, 30 by default (but we recommend 10-20)
     min-complexity: 20
@@ -182,11 +186,6 @@ linters-settings:
   nestif:
     # minimal complexity of if statements to report, 5 by default
     min-complexity: 4
-  gomnd:
-    settings:
-      mnd:
-        # don't include the "operation" and "assign"
-        checks: argument,case,condition,return
   unused:
     # treat code as a program (not a library) and report unused exported identifiers; default is false.
     # XXX: if you enable this setting, unused will report a lot of false-positives in text editors:
@@ -258,7 +257,7 @@ linters:
     # - dupl
     - errcheck
     - errorlint
-    - exportloopref
+    - copyloopvar
     - exhaustive
     - forbidigo
     - funlen
@@ -269,7 +268,6 @@ linters:
     - gofmt
     - goheader
     - goimports
-    # - gomnd
     - goprintffuncname
     - gosec
     - gosimple