Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add considerations for changing outputs in a policy #1038

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

kilfoyle
Copy link
Contributor

@kilfoyle kilfoyle commented Apr 18, 2024

@asmith-elastic Thanks a lot for putting so much detail into the issue. It helped a lot!

Please have a look and let me know if things are okay.

Preview:


Screenshot 2024-04-23 at 1 55 16 PM

Closes: #1035

@kilfoyle kilfoyle requested a review from a team as a code owner April 18, 2024 19:23
@kilfoyle kilfoyle marked this pull request as draft April 18, 2024 19:23
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Apr 18, 2024

This pull request does not have a backport label. Could you fix it @kilfoyle? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@kilfoyle kilfoyle requested a review from asmith-elastic April 23, 2024 17:57
@kilfoyle kilfoyle marked this pull request as ready for review April 23, 2024 17:58
@asmith-elastic
Copy link
Contributor

@kilfoyle - Thank you so much for getting this pull request created, everything looks good from my point of view! Let me know if you need anything else from my end. Appreciate your help!

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@kilfoyle
Copy link
Contributor Author

@elasticmachine run docs-build

@kilfoyle kilfoyle merged commit 85b7bb8 into elastic:main Apr 23, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
* Add considerations for changing outputs

* fixup

(cherry picked from commit 85b7bb8)
mergify bot pushed a commit that referenced this pull request Apr 23, 2024
* Add considerations for changing outputs

* fixup

(cherry picked from commit 85b7bb8)
kilfoyle added a commit that referenced this pull request Apr 23, 2024
* Add considerations for changing outputs

* fixup

(cherry picked from commit 85b7bb8)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle added a commit that referenced this pull request Apr 23, 2024
* Add considerations for changing outputs

* fixup

(cherry picked from commit 85b7bb8)

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REQUEST]: Provide warnings detailing the potential risks of changing policy outputs
3 participants