Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fleet-agent-proxy-package-registry.asciidoc #1722

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

lucabelluccini
Copy link
Contributor

I've looked in the code and credentials can be provided via xpack.fleet.registryProxyUrl: https://username:password@proxyhost:proxyport. Note for security reasons this is only allowed when using https.
On top of this, I've discovered that when using HTTPS Proxy we also ignore invalid certs by default.

https://github.com/elastic/kibana/blob/2a32ed4755c0f4852dc234b72ce5ad278a0ad593/x-pack/platform/plugins/shared/fleet/server/services/epm/registry/proxy.ts#L40C9-L40C20

@lucabelluccini lucabelluccini requested a review from a team as a code owner March 6, 2025 12:06
Copy link

github-actions bot commented Mar 6, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link

github-actions bot commented Mar 6, 2025

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Mar 6, 2025

This pull request does not have a backport label. Could you fix it @lucabelluccini? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Mar 6, 2025
@lucabelluccini
Copy link
Contributor Author

This has to be back ported to at least 8.x and 7.17.x

@lucabelluccini
Copy link
Contributor Author

lucabelluccini commented Mar 6, 2025

FYI @kilfoyle & @kpollich

@kilfoyle
Copy link
Contributor

kilfoyle commented Mar 6, 2025

Hi @lucabelluccini Thanks for opening this! The "Set the proxy URL" page exists only in the 8.x docs and not 7.17 (it was added in 8.10 I think). So I can backport into 8.18 and 8.17 (which is now current).

Note that we're not allowed to update earlier, non-current versions of the docs, since we have a banner at the top of those pages telling users that "No additional bug fixes or documentation updates will be released for this version.", and we don't want to false advertise. :-)

kilfoyle
kilfoyle previously approved these changes Mar 6, 2025
Copy link

github-actions bot commented Mar 6, 2025

Warning

It looks like this PR modifies one or more .asciidoc files. These files are being migrated to Markdown, and any changes merged now will be lost. See the migration guide for details.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kilfoyle kilfoyle merged commit 73cea8c into main Mar 6, 2025
3 of 4 checks passed
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)
mergify bot pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)
kilfoyle pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
kilfoyle pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
kilfoyle pushed a commit that referenced this pull request Mar 6, 2025
* Update fleet-agent-proxy-package-registry.asciidoc

* Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
(cherry picked from commit 73cea8c)

Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
kilfoyle added a commit to elastic/docs-content that referenced this pull request Mar 6, 2025
This forward fits a small change from
elastic/ingest-docs#1722 to add details for
setting a proxy URL for the EPR.

(Karen, this is the forward fit I mentioned for the PR from earlier
today)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants