-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fleet-agent-proxy-package-registry.asciidoc #1722
Conversation
Warning It looks like this PR modifies one or more |
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @lucabelluccini? 🙏
|
This has to be back ported to at least 8.x and 7.17.x |
Hi @lucabelluccini Thanks for opening this! The "Set the proxy URL" page exists only in the 8.x docs and not 7.17 (it was added in 8.10 I think). So I can backport into 8.18 and 8.17 (which is now current). Note that we're not allowed to update earlier, non-current versions of the docs, since we have a banner at the top of those pages telling users that "No additional bug fixes or documentation updates will be released for this version.", and we don't want to false advertise. :-) |
docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc
Outdated
Show resolved
Hide resolved
Warning It looks like this PR modifies one or more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c)
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c)
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c)
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c) Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c) Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
* Update fleet-agent-proxy-package-registry.asciidoc * Update docs/en/ingest-management/fleet-agent-proxy-package-registry.asciidoc --------- Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com> (cherry picked from commit 73cea8c) Co-authored-by: Luca Belluccini <luca.belluccini@elastic.co>
This forward fits a small change from elastic/ingest-docs#1722 to add details for setting a proxy URL for the EPR. (Karen, this is the forward fit I mentioned for the PR from earlier today)
I've looked in the code and credentials can be provided via
xpack.fleet.registryProxyUrl: https://username:password@proxyhost:proxyport
. Note for security reasons this is only allowed when usinghttps
.On top of this, I've discovered that when using HTTPS Proxy we also ignore invalid certs by default.
https://github.com/elastic/kibana/blob/2a32ed4755c0f4852dc234b72ce5ad278a0ad593/x-pack/platform/plugins/shared/fleet/server/services/epm/registry/proxy.ts#L40C9-L40C20