Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix Elastic Agent input examples #915

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Conversation

renshuki
Copy link
Contributor

ssl and ssl_verify_mode settings are deprecated for the Elastic Agent input (Logstash).
I adjusted the examples with current valid settings: ssl_enabled and ssl_client_authentication based of latest Logstash documentation: https://www.elastic.co/guide/en/logstash/current/plugins-inputs-elastic_agent.html#plugins-inputs-elastic_agent-ssl_client_authentication

@renshuki renshuki requested a review from a team as a code owner February 13, 2024 02:22
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

mergify bot commented Feb 13, 2024

This pull request does not have a backport label. Could you fix it @renshuki? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for fixing this @renshuki!

@kilfoyle
Copy link
Contributor

I'm not sure if you have merge permissions (the security permissions on all of our repos changed recently), so I'll merge this. I hope that's okay!

@kilfoyle kilfoyle merged commit 8c7df57 into elastic:main Feb 13, 2024
4 checks passed
mergify bot pushed a commit that referenced this pull request Feb 13, 2024
kilfoyle pushed a commit that referenced this pull request Feb 13, 2024
(cherry picked from commit 8c7df57)

Co-authored-by: Francois-Clement Brossard <renshuki@users.noreply.github.com>
@renshuki
Copy link
Contributor Author

I'm not sure if you have merge permissions (the security permissions on all of our repos changed recently), so I'll merge this. I hope that's okay!

Thanks @kilfoyle! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants