Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding info for conditions for autodiscovery #921

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Adding info for conditions for autodiscovery #921

merged 4 commits into from
Feb 20, 2024

Conversation

gizas
Copy link
Contributor

@gizas gizas commented Feb 15, 2024

Small section that adds some info for autodiscovery template definition for K8s

@gizas gizas requested a review from a team as a code owner February 15, 2024 12:59
@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 15, 2024

This pull request does not have a backport label. Could you fix it @gizas? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-/d./d is the label to automatically backport to the /d./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

gizas and others added 2 commits February 15, 2024 17:21
@gizas @kilfoyle
Update docs/en/ingest-management/elastic-agent/configuration/autodisc…
a45d016 
…overy/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
@gizas @kilfoyle
Update docs/en/ingest-management/elastic-agent/configuration/autodisc…
d4739e5 
…overy/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
kilfoyle
kilfoyle previously approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

gsantoro
gsantoro suggested changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@gsantoro gsantoro left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo

@gizas @gsantoro
Update docs/en/ingest-management/elastic-agent/configuration/autodisc…
e574f2e 
…overy/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
@gizas
Copy link
Contributor Author

gizas commented Feb 19, 2024

@kilfoyle same issue I can not merge. So if you dont have any objection please ...

kilfoyle
kilfoyle approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
Merging...

@kilfoyle kilfoyle merged commit e78f808 into elastic:main Feb 20, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
@gizas @mergify
Adding info for conditions for autodiscovery (#921)
fb57f6b 
* Adding info for conditions

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
(cherry picked from commit e78f808)
mergify bot pushed a commit that referenced this pull request Feb 20, 2024
@gizas @mergify
Adding info for conditions for autodiscovery (#921)
23ca4a0 
* Adding info for conditions

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
(cherry picked from commit e78f808)
This was referenced Feb 20, 2024
Merged
Merged
kilfoyle pushed a commit that referenced this pull request Feb 20, 2024
@mergify @gizas
Adding info for conditions for autodiscovery (#921) (#936)
09e8f29 
* Adding info for conditions

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
(cherry picked from commit e78f808)

Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
kilfoyle pushed a commit that referenced this pull request Feb 20, 2024
@mergify @gizas
Adding info for conditions for autodiscovery (#921) (#937)
af2afc7 
* Adding info for conditions

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>

* Update docs/en/ingest-management/elastic-agent/configuration/autodiscovery/kubernetes-conditions-autodiscover.asciidoc

Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>

---------

Co-authored-by: David Kilfoyle <41695641+kilfoyle@users.noreply.github.com>
Co-authored-by: Giuseppe Santoro <giuseppe.santoro@elastic.co>
(cherry picked from commit e78f808)

Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsantoro gsantoro gsantoro approved these changes

@kilfoyle kilfoyle kilfoyle approved these changes

@constanca-m constanca-m constanca-m approved these changes

@MichaelKatsoulis MichaelKatsoulis Awaiting requested review from MichaelKatsoulis

@tetianakravchenko tetianakravchenko Awaiting requested review from tetianakravchenko

Assignees
No one assigned
Labels
backport-8.11 backport-8.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gizas @gsantoro @kilfoyle @constanca-m