-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Add variable to the preconfiguration example #981
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
This pull request does not have a backport label. Could you fix it @nchaulet? 🙏
|
@@ -49,7 +49,7 @@ xpack.fleet.agentPolicies: | |||
name: fleet_server | |||
---- | |||
|
|||
The following example creates an agent policy for general use: | |||
The following example creates an agent policy for general use, that customize the period for the system.core metrics: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kilfoyle will it make sense to add something to tell the user they can find all the available input and variable in the integration UI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nchaulet I think that makes sense. Do you think it might be better to refer people to the Integrations documentation rather than the UI? Usually the docs are better as a reference, but I don't see that period
setting described on the System integration page.
Depending on which is better (refer people to the docs or to the UI), here are a couple of suggestions for the text.
Refer users to the docs:
The following example creates an agent policy for general use, and customizes the `period` setting for the `system.core` data stream. All available inputs and variables are described in the link:https://docs.elastic.co/en/integrations[Integrations] documentation.
Refer users to the UI:
The following example creates an agent policy for general use, and customizes the `period` setting for the `system.core` data stream. You can find all available inputs and variables in the **Integrations** app in {kib}.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it might be better to refer people to the Integrations documentation rather than the UI? Usually the docs are better as a reference, but I don't see that period setting described on the System integration page.
Unfortunately I do not think we have the information in the Integrations documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
Thanks @nchaulet!
Description
Resolve elastic/kibana#159444
Add variable to the preconfiguration example