[Fleet] adding upgrade details UPG_FAILED check to stuck in updating #173628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
juliaElastic
commented
Dec 19, 2023
| !agent.upgraded_at && | ||
| Date.now() - Date.parse(agent.upgrade_started_at) > | ||
| AGENT_UPDATING_TIMEOUT_HOURS * 60 * 60 * 1000 | ||
| (agent.status !== 'offline' && agent.active && isAgentInFailedUpgradeState(agent)) || |
There was a problem hiding this comment.
after the latest discussion here changed the logic to consider stuck in updating if upgrade failed, even though agent is back to online
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 21, 2023
…lastic#173628) ## Summary Closes elastic#171419 Added upgrade details check to restart upgrade callout when agent is stuck in updating. Changed the copy slightly when the agent has failed upgrade state. <img width="653" alt="image" src="https://github.com/elastic/kibana/assets/90178898/50061732-aa92-495b-b683-4d96114a1d5a"> Existing copy when there is no upgrade details (stuck in updating for more than 2 hours): <img width="609" alt="image" src="https://github.com/elastic/kibana/assets/90178898/14413c4a-ce51-49fa-a217-68993c4378fd"> Adjusted Agent list tooltip as well if upgrade details state is failed. <img width="513" alt="image" src="https://github.com/elastic/kibana/assets/90178898/6836e02e-2c30-4c0a-91ea-8baddb0ccf03"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 1f3d3ea)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 21, 2023
…dating (#173628) (#173807) # Backport This will backport the following commits from `main` to `8.12`: - [[Fleet] adding upgrade details UPG_FAILED check to stuck in updating (#173628)](#173628) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Julia Bardi","email":"90178898+juliaElastic@users.noreply.github.com"},"sourceCommit":{"committedDate":"2023-12-21T08:06:02Z","message":"[Fleet] adding upgrade details UPG_FAILED check to stuck in updating (#173628)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/171419\r\n\r\nAdded upgrade details check to restart upgrade callout when agent is\r\nstuck in updating.\r\nChanged the copy slightly when the agent has failed upgrade state.\r\n\r\n<img width=\"653\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/50061732-aa92-495b-b683-4d96114a1d5a\">\r\n\r\nExisting copy when there is no upgrade details (stuck in updating for\r\nmore than 2 hours):\r\n<img width=\"609\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/14413c4a-ce51-49fa-a217-68993c4378fd\">\r\n\r\nAdjusted Agent list tooltip as well if upgrade details state is failed.\r\n\r\n<img width=\"513\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/6836e02e-2c30-4c0a-91ea-8baddb0ccf03\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1f3d3eaaa703ddc470ebe3e2e6140cd068434f14","branchLabelMapping":{"^v8.13.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v8.12.0","v8.13.0"],"number":173628,"url":"https://github.com/elastic/kibana/pull/173628","mergeCommit":{"message":"[Fleet] adding upgrade details UPG_FAILED check to stuck in updating (#173628)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/171419\r\n\r\nAdded upgrade details check to restart upgrade callout when agent is\r\nstuck in updating.\r\nChanged the copy slightly when the agent has failed upgrade state.\r\n\r\n<img width=\"653\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/50061732-aa92-495b-b683-4d96114a1d5a\">\r\n\r\nExisting copy when there is no upgrade details (stuck in updating for\r\nmore than 2 hours):\r\n<img width=\"609\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/14413c4a-ce51-49fa-a217-68993c4378fd\">\r\n\r\nAdjusted Agent list tooltip as well if upgrade details state is failed.\r\n\r\n<img width=\"513\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/6836e02e-2c30-4c0a-91ea-8baddb0ccf03\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1f3d3eaaa703ddc470ebe3e2e6140cd068434f14"}},"sourceBranch":"main","suggestedTargetBranches":["8.12"],"targetPullRequestStates":[{"branch":"8.12","label":"v8.12.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.13.0","labelRegex":"^v8.13.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/173628","number":173628,"mergeCommit":{"message":"[Fleet] adding upgrade details UPG_FAILED check to stuck in updating (#173628)\n\n## Summary\r\n\r\nCloses https://github.com/elastic/kibana/issues/171419\r\n\r\nAdded upgrade details check to restart upgrade callout when agent is\r\nstuck in updating.\r\nChanged the copy slightly when the agent has failed upgrade state.\r\n\r\n<img width=\"653\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/50061732-aa92-495b-b683-4d96114a1d5a\">\r\n\r\nExisting copy when there is no upgrade details (stuck in updating for\r\nmore than 2 hours):\r\n<img width=\"609\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/14413c4a-ce51-49fa-a217-68993c4378fd\">\r\n\r\nAdjusted Agent list tooltip as well if upgrade details state is failed.\r\n\r\n<img width=\"513\" alt=\"image\"\r\nsrc=\"https://github.com/elastic/kibana/assets/90178898/6836e02e-2c30-4c0a-91ea-8baddb0ccf03\">\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>","sha":"1f3d3eaaa703ddc470ebe3e2e6140cd068434f14"}}]}] BACKPORT--> Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #171419
Added upgrade details check to restart upgrade callout when agent is stuck in updating.
Changed the copy slightly when the agent has failed upgrade state.
Existing copy when there is no upgrade details (stuck in updating for more than 2 hours):
Adjusted Agent list tooltip as well if upgrade details state is failed.
Checklist