[8.x] [Security Solution][Detection Engine] Remove CreateRuleOptions, pass options through security rule wrapper instead (#216039) #216383
+120
−165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…options through security rule wrapper instead (elastic#216039) ## Summary Another small refactor follow up to elastic#212694. Overall, the goal here is to increase consistency in how security rule executors receive common parameters. `CreateRuleOptions` contained parameters that were passed in to every security rule type and sometimes used in the `executor` - bypassing the executor function's parameters. With this PR, params that are used across multiple security rule type executors like `licensing`, `experimentalFeatures`, `scheduleNotificationResponseActionsService`, etc are all passed through the executor options from the shared security rule type wrapper. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 0e63fce) # Conflicts: # x-pack/solutions/security/plugins/security_solution/server/lib/detection_engine/rule_types/query/create_query_alert_type.test.ts # x-pack/solutions/security/plugins/security_solution/server/plugin.ts
dhurley14
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation