Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Fixed layout when monitors are grouped by #216434

Merged
merged 2 commits into from
Apr 2, 2025

Conversation

cesco-f
Copy link
Contributor

@cesco-f cesco-f commented Mar 31, 2025

This PR closes #207560.

Before:
Screenshot 2025-03-31 at 12 01 55

After:
Screenshot 2025-03-31 at 12 02 19

@cesco-f cesco-f added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels v8.19.0 labels Mar 31, 2025
@cesco-f cesco-f requested a review from a team as a code owner March 31, 2025 10:04
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Mar 31, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 988.0KB 988.0KB +18.0B

History

Copy link
Contributor

@dominiqueclarke dominiqueclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested with 26 tags and looked good.

@cesco-f cesco-f merged commit bb397cc into elastic:main Apr 2, 2025
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/14213947009

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 2, 2025
This PR closes elastic#207560.

Before:
<img width="1512" alt="Screenshot 2025-03-31 at 12 01 55"
src="https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc"
/>

After:
<img width="1512" alt="Screenshot 2025-03-31 at 12 02 19"
src="https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3"
/>

(cherry picked from commit bb397cc)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cesco-f cesco-f deleted the fix-layout branch April 2, 2025 07:45
kibanamachine added a commit that referenced this pull request Apr 2, 2025
#216750)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fixed layout when monitors are grouped by
(#216434)](#216434)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-04-02T07:27:10Z","message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0"],"title":"[Synthetics]
Fixed layout when monitors are grouped
by","number":216434,"url":"https://github.com/elastic/kibana/pull/216434","mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216434","number":216434,"mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
@cesco-f cesco-f added v9.0.1 backport:version Backport to applied version labels and removed backport:version Backport to applied version labels labels Apr 2, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14223822465

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 2, 2025
This PR closes elastic#207560.

Before:
<img width="1512" alt="Screenshot 2025-03-31 at 12 01 55"
src="https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc"
/>

After:
<img width="1512" alt="Screenshot 2025-03-31 at 12 02 19"
src="https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3"
/>

(cherry picked from commit bb397cc)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.x Cherrypick failed because the selected commit (bb397cc) is empty. It looks like the commit was already backported in #216750
9.0

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 216434

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 2, 2025
#216882)

# Backport

This will backport the following commits from `main` to `9.0`:
- [[Synthetics] Fixed layout when monitors are grouped by
(#216434)](#216434)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-04-02T07:27:10Z","message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v9.0.1"],"title":"[Synthetics]
Fixed layout when monitors are grouped
by","number":216434,"url":"https://github.com/elastic/kibana/pull/216434","mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216434","number":216434,"mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216750","number":216750,"state":"MERGED","mergeCommit":{"sha":"12bb59fa8f48d0c2ac529caad0f58fa09308f365","message":"[8.x]
[Synthetics] Fixed layout when monitors are grouped by (#216434)
(#216750)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[Synthetics] Fixed layout when monitors are grouped
by\n(#216434)](https://github.com/elastic/kibana/pull/216434)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Francesco Fagnani
<fagnani.francesco@gmail.com>"}},{"branch":"9.0","label":"v9.0.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
@dominiqueclarke dominiqueclarke added v8.18.1 and removed backport:version Backport to applied version labels labels Apr 3, 2025
@dominiqueclarke dominiqueclarke added the backport:version Backport to applied version labels label Apr 3, 2025
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.18, 8.x, 9.0

https://github.com/elastic/kibana/actions/runs/14251687131

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Apr 3, 2025
This PR closes elastic#207560.

Before:
<img width="1512" alt="Screenshot 2025-03-31 at 12 01 55"
src="https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc"
/>

After:
<img width="1512" alt="Screenshot 2025-03-31 at 12 02 19"
src="https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3"
/>

(cherry picked from commit bb397cc)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.18
8.x Cherrypick failed because the selected commit (bb397cc) is empty. It looks like the commit was already backported in #216750
9.0 Cherrypick failed because the selected commit (bb397cc) is empty. It looks like the commit was already backported in #216882

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 216434

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Apr 3, 2025
… (#217104)

# Backport

This will backport the following commits from `main` to `8.18`:
- [[Synthetics] Fixed layout when monitors are grouped by
(#216434)](#216434)

<!--- Backport version: 9.6.6 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sorenlouv/backport)

<!--BACKPORT [{"author":{"name":"Francesco
Fagnani","email":"fagnani.francesco@gmail.com"},"sourceCommit":{"committedDate":"2025-04-02T07:27:10Z","message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:obs-ux-management","backport:version","v9.1.0","v8.19.0","v8.18.1","v9.0.1"],"title":"[Synthetics]
Fixed layout when monitors are grouped
by","number":216434,"url":"https://github.com/elastic/kibana/pull/216434","mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},"sourceBranch":"main","suggestedTargetBranches":["8.18"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216882","number":216882,"state":"MERGED","mergeCommit":{"sha":"d1ba622e36b556b4dcea64cf410474cfbfef3946","message":"[9.0]
[Synthetics] Fixed layout when monitors are grouped by (#216434)
(#216882)\n\n# Backport\n\nThis will backport the following commits from
`main` to `9.0`:\n- [[Synthetics] Fixed layout when monitors are grouped
by\n(#216434)](https://github.com/elastic/kibana/pull/216434)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Francesco Fagnani
<fagnani.francesco@gmail.com>"}},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/216434","number":216434,"mergeCommit":{"message":"[Synthetics]
Fixed layout when monitors are grouped by (#216434)\n\nThis PR closes
#207560.\n\nBefore:\n<img width=\"1512\" alt=\"Screenshot 2025-03-31 at
12 01
55\"\nsrc=\"https://github.com/user-attachments/assets/eee8e848-0df5-45af-a53d-8ee3c24a84fc\"\n/>\n\nAfter:\n<img
width=\"1512\" alt=\"Screenshot 2025-03-31 at 12 02
19\"\nsrc=\"https://github.com/user-attachments/assets/841b537e-4f55-40e1-b76f-4492812f2da3\"\n/>","sha":"bb397ccd9ee2fa72f168468dbcc2c65daa71a228"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/216750","number":216750,"state":"MERGED","mergeCommit":{"sha":"12bb59fa8f48d0c2ac529caad0f58fa09308f365","message":"[8.x]
[Synthetics] Fixed layout when monitors are grouped by (#216434)
(#216750)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[Synthetics] Fixed layout when monitors are grouped
by\n(#216434)](https://github.com/elastic/kibana/pull/216434)\n\n\n\n###
Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sorenlouv/backport)\n\n\n\nCo-authored-by:
Francesco Fagnani
<fagnani.francesco@gmail.com>"}},{"branch":"8.18","label":"v8.18.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Francesco Fagnani <fagnani.francesco@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v8.18.0 v8.18.1 v8.19.0 v9.0.0 v9.0.1 v9.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Synthetics UI] Group by monitors
4 participants