fix + reformat linux/macos collector commands #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of
&&
at the end of variables setting makes them ignored in the following sed (at least in my local setup).we can simplify a bit and remove the
rm
command as the file is overwriten with thecp
command, also we can simplify escaping by making the sed expression interpolated rather than concatenated.With those changes, the only difference between the macos and linux is the extra
''
argument in the inline sed invocation.