Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix + reformat linux/macos collector commands #119

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

SylvainJuge
Copy link
Member

The lack of && at the end of variables setting makes them ignored in the following sed (at least in my local setup).

we can simplify a bit and remove the rm command as the file is overwriten with the cp command, also we can simplify escaping by making the sed expression interpolated rather than concatenated.

With those changes, the only difference between the macos and linux is the extra '' argument in the inline sed invocation.

@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/quickstart/self-managed/hosts_vms.md 64 26 38 42

*TBD

@elastic-acrolinx
Copy link

Acrolinx Scorecards

Select the total score link to review all feedback on clarity, consistency, tone, brand, terms, spelling, grammar, readability, and inclusive language. You should fix all spelling errors regardless of your total score. Fixing spelling errors helps maintain user trust in overall content quality.

Article Total score
(Required: 80)
Words + phrases
(Brand, terms)
Correctness
(Spelling, grammar)
Clarity
(Readability)
docs/quickstart/self-managed/hosts_vms.md 64 26 38 42

*TBD

@AlexanderWert AlexanderWert merged commit 46ee5d3 into elastic:main Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants