Merge main into 8.16 branch #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding fix for host.name field update based on k8s.node.name
…gurability (#33) * use release versions of the elastic-otel-node and elastic-otel-python Docker images * chore: add components documentation * chore: add service attributes annotations * fix: reduce words in favor of hyprlink * fix: api and endpoints annotations * Update resources/kubernetes/operator/helm/values.yaml Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> * docs: add values and zero-code links * chore: add pod resource * move links to hyperlinks * Update resources/kubernetes/operator/helm/values.yaml Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com> * Update resources/kubernetes/operator/helm/values.yaml Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com> --------- Co-authored-by: Andrew Gizas <andreas.gkizas@elastic.co> Co-authored-by: Edu González de la Herrán <25320357+eedugon@users.noreply.github.com>
gizas
reviewed
Oct 29, 2024
|
|
||
| defaultCRConfig: | ||
| image: | ||
| repository: "docker.elastic.co/beats/elastic-agent" | ||
| tag: "8.16.0-SNAPSHOT" | ||
| targetAllocator: | ||
| enabled: false | ||
| enabled: false # Enable/disable the Operator's Target allocator. | ||
| # Refer to: https://github.com/open-telemetry/opentelemetry-operator/tree/main/cmd/otel-allocator |
There was a problem hiding this comment.
nit: dont like it so much that is in 2 lines
Maybe to move Refer line before targetAllocator and line 23?
There was a problem hiding this comment.
Sounds good to me, but I think we will need to do this in another PR to keep the history aligned with main
gizas
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.