Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s-otel: cert-manager integration information added #41

Merged
merged 23 commits into from
Nov 5, 2024

Conversation

eedugon
Copy link
Contributor

@eedugon eedugon commented Oct 30, 2024

Closes https://github.com/elastic/opentelemetry-dev/issues/568

I've added details about cert-manager integrated installations of the Otel Operator.

It will be also pointed by Kibana onboarding UX link added in elastic/kibana#197620

@eedugon eedugon requested review from gizas, mlunadia, rogercoll and a team October 30, 2024 15:36
Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eedugon
Copy link
Contributor Author

eedugon commented Oct 30, 2024

@mdbirnstiehl : it would be great if you can review this PR (eventually I'd like you to review with me the entire set of documents that we are creating for Otel + k8s, but let's start with this).

Thanks!!
cc: @bmorelli25

@bmorelli25 bmorelli25 requested review from mdbirnstiehl and removed request for a team October 30, 2024 21:19
Copy link
Contributor

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I had a few comments and suggestions. Let me know if you have any questions or comments or would like additional clarification.

eedugon and others added 13 commits October 31, 2024 10:12
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
eedugon and others added 2 commits November 4, 2024 17:58
Co-authored-by: Mike Birnstiehl <114418652+mdbirnstiehl@users.noreply.github.com>
@eedugon eedugon merged commit ac9b5d7 into elastic:main Nov 5, 2024
1 check passed
@eedugon eedugon deleted the cert_manager_instructions branch November 7, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants