Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade prettier to avoid dynamic imports #58

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

miguelgrinberg
Copy link
Contributor

Fixes #57

Not sure if this is the best solution or not, but trying out ways to avoid having to use the experimental-vm-modules I've found that the 2.x prettier versions do not have this issue. This PR downgrades to the latest 2.x, which seems to work fine.

@miguelgrinberg miguelgrinberg requested a review from JoshMock August 9, 2024 18:25
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally acceptable. I wasn't thinking about the downstream consequences of using Prettier 3.x. Thanks for fixing!

@miguelgrinberg miguelgrinberg merged commit 64aff77 into main Aug 12, 2024
23 checks passed
@miguelgrinberg miguelgrinberg deleted the downgrade-prettier branch August 12, 2024 15:46
github-actions bot pushed a commit that referenced this pull request Aug 12, 2024
miguelgrinberg added a commit that referenced this pull request Aug 12, 2024
(cherry picked from commit 64aff77)

Co-authored-by: Miguel Grinberg <miguel.grinberg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dynamic import errors in Kibana
2 participants