Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GCS output and fixing linting issues for few outputs #46

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Nov 23, 2022

Adding support for reading files and sending them to a GCS bucket, or create the bucket if it does not already exist.

@elasticmachine
Copy link

elasticmachine commented Nov 23, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-18T10:28:47.800+0000

  • Duration: 6 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@P1llus P1llus changed the title Adding GCS output Adding GCS output and fixing linting issues for few outputs Nov 23, 2022
@P1llus
Copy link
Member Author

P1llus commented Nov 23, 2022

I also fixed some imports of ioutil which is now deprecated, and the linter was complaining, this includes other outputs as well

@P1llus P1llus requested a review from andrewkroh November 24, 2022 08:29
@P1llus
Copy link
Member Author

P1llus commented Nov 24, 2022

@andrewkroh I am adding in the second environmental variable again, as it otherwise breaks the client:
image

@P1llus P1llus requested a review from andrewkroh January 17, 2023 10:27
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the project readme to include GCS.

@P1llus P1llus merged commit b0c8885 into elastic:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants