-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
automation - add changelog and release automation #86
Conversation
Add a new Github workflow for releases that automates the generation of a draft GH release with changelog notes. Pull requests will be required to add new file to at .changelog/<pr_number>.txt with a changelog message or label with skip-changelog to bypass the check. See CONTRIBUTING.md for more details. This backfills the .changelog directory with entries for changes since v0.14.0.
CONTRIBUTING.md
Outdated
- Include a [changelog][changelog_docs] entry at `.changelog/{pr-number}.txt` with your pull request. | ||
- Include tests that demonstrate the change is working. | ||
|
||
[changelog_docs]: https://github.com/GoogleCloudPlatform/magic-modules/blob/2834761fec3acbf35cacbffe100530f82eada650/.ci/RELEASE_NOTES_GUIDE.md#expected-format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see this line at all on the rendered github view: https://github.com/andrewkroh/stream/blob/release-workflow/CONTRIBUTING.md
But maybe there could be a template or examples of the format in this repo. I don't find the linked page very clear. Should there be a PR description before the release note? From the changelog in this PR, I guess not, but the doc makes it seem like it should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added more explanation and examples in the CONTRIBUTING.md. After a few changes are made there will be many examples to follow in the .changelog/ dir.
Describe the .changelog/*.txt file format.
cf6a953
to
d5205b5
Compare
d5205b5
to
b541db5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a shame to lose the old change log info (I know it's in the releases page — this is not committed).
I could move it to something like |
That SGTM |
Add a new Github workflow for releases that automates the generation of a draft GH release with changelog notes.
Pull requests will be required to add new file to at
.changelog/<pr_number>.txt
with a changelog message or label withskip-changelog
to bypass the check. See CONTRIBUTING.md for more details.This backfills the .changelog directory with entries for changes since v0.14.0.
(I cloned this from go-sysinfo.)