-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(electron-publish): add gitlab publisher #9209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(electron-publish): add gitlab publisher #9209
Conversation
🦋 Changeset detectedLatest commit: a485f93 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@mmaietta fyi |
@mmaietta by the way, let me know your comments about docs update, better to provide some guide then I can know how to update. |
Did you change something in your Gitlab repo? I may need to fork it...because tests broke seem to have been continually broken on master |
Do you see any gitlab related errors logs?
I see many above github 503 errors. |
@mmaietta Sorry, I published a new version v1.1.0 in gitlab repo in order to test I've created a separate PR (#9221) to fix the failing tests, so they no longer block the CI on the master branch. This was a silly mistake—really sorry about that. I should have created a new dedicated gitlab repo specifically for Do you have any thoughts or suggestions on this approach? |
This is what I do. There's not really a simple way other than that since it needs to be a full e2e test with github/gitlab/etc. |
14b214c
to
4c0efc0
Compare
- Remove CI_PROJECT_ID and CI_PROJECT_PATH related code that requires user must provide projectId in configuration - Remove fallback value of token header, furthermore extract a new function `setAuthHeaderForToken()` in httpExecutor.ts to handle gitlab related token header correctly - Throw error directly in the helper method `getAllReleases()`
886c67e
to
124d2f2
Compare
…der in gitlabProvider and gitlabPublisher
There are two tests( |
I've created a dedicated PR to fix these two flaky tests #9251 |
As title, this is a new feat about gitlab publisher referring to the existing behaviors of githubPublisher. With this feat then we can fully support gitlab platform combined with GitlabUpdater.
Notes:
(For reference, the tests have been verified successfully in my local environment.)
Details about new interface
getBlockMapFiles()
inProvider
:The legacy behavior required the block map file to be in the same folder as the base file. However, when publishing GitLab assets via
project_upload
, GitLab generates a unique path for each asset, making the legacy approach ineffective. To address this, I introduced a newgetBlockMapFiles()
interface inProvider
and moved the legacy logic into a default implementation. This allowsGitlabProvider
to override the method with custom logic. It’s a more flexible solution and remains backward compatible.