perf: cache the return value of IsX11()
#46391
Merged
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
performance 🏁
semver/patch
VerteDinde
approved these changes
Mar 31, 2025
deepak1556
approved these changes
Apr 1, 2025
|
No Release Notes |
This was referenced Apr 1, 2025
|
I have automatically backported this PR to "35-x-y", please check out #46425 |
trop
bot
added
in-flight/35-x-y
and removed
target/35-x-y
|
I have automatically backported this PR to "34-x-y", please check out #46426 |
|
I have automatically backported this PR to "36-x-y", please check out #46427 |
trop
bot
added
in-flight/34-x-y
in-flight/36-x-y
merged/34-x-y
trop
bot
added
merged/36-x-y
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The return value of
IsX11()isn't ever going to change during an Electron session, and it's cheap to cache the return value in astatic const bool, so let's do that instead of re-running the test every time the function is called.Also, add a
[[nodiscard]]annotation to indicate that callers should use the return value.Checklist
npm testpassesRelease Notes
Notes: none.