Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move _should_stop initialization to __init__ #426

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Move _should_stop initialization to __init__ #426

merged 1 commit into from
Dec 9, 2024

Conversation

tudor11l
Copy link
Collaborator

@tudor11l tudor11l commented Dec 9, 2024

Avoid using mutable default values for _should_stop by initializing it in the init method to ensure instance-level independence.

@tudor11l
Move _should_stop initialization to __init__
ac0b46f 
Avoid using mutable default values for _should_stop by initializing it in the __init__ method to ensure instance-level independence.
@tudor11l tudor11l added the bug Something isn't working label Dec 9, 2024
@tudor11l tudor11l requested a review from lacop11 December 9, 2024 20:59
@tudor11l tudor11l self-assigned this Dec 9, 2024
lacop11
lacop11 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@lacop11 lacop11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lacop11 lacop11 merged commit c19ad6e into main Dec 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lacop11 lacop11 lacop11 approved these changes

Assignees

@tudor11l tudor11l

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tudor11l @lacop11