-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rearchitect models to be able to include if you have a GPU or not #1257
Conversation
Questions that come to mind:
|
|
This pull request has been automatically marked as stale due to 30 days of inactivity. |
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Risks
Medium, maybe this isn't the direction we want
Background
What does this PR do?
Rearchitected how model settings are fetched, so it is known if you have a GPU or not when we generate the list
What kind of change is this?
Improvements (misc. changes to existing features)
Why are we doing this? Any context or related work?
This allows us to select a quicker model if you do not have a GPU and a higher quality model if you have a GPU, improving first-time run experience
Documentation changes needed?
My changes do not require a change to the project documentation.