-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add advanced trading #1340
Conversation
is the goal to convert this to typescript? |
yessirEl dic 21, 2024, a la(s) 19:40, chris ***@***.***> escribió:
is the goal to convert this to typescript?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
hey fam, thank you for reviewing. please lmk if it is necessary to convert to typescript prior to a PR. all of my quant stuff is in python but im willing to learn ts and convert it if needed also the integration tests are failing due to the need of api keys: birdeye, helius rpc and solana private key. is there a secure way i can send mine? im @moondev on discord cheers |
Hey @moondevonyt good stuffs! I would need to do an extensive test and also bring it up with other team members before deciding if port to typescript or not (I might be able to help and support if that will be the case though). Also, the integration tests failure is due to script not finding the OPEN API key (not from your end). |
hey @shakkernerd thank you very much for your help w review and ts. tomorrow i was planning on building a python shell to make it all useable from typescript, but i would be curious do you think it is a better use of time doing that, or re-writing in ts? i have a ton to contribute from the quant side, virtually all in python so i will do whatever is needed to be done to allow the agents to leverage my libraries thank you sir |
0178da0
to
85942b4
Compare
Hey @moondevonyt tbh, I don't know how much work it would be to port the code from python to typescript. I can take a look to see how much work it would be. Another thing that comes to mind is if the libs used in your code will be available in typescript. Thank you for doing all these really! |
UPDATE: looks like we might allow python in but we need to see how its going to sync with the entire framework. |
the dataframe import and the financial classes seem the oddest to replicate, with d3 (https://stackoverflow.com/questions/30610675/python-pandas-equivalent-in-javascript) for the former and for the latter as inspo:
@moondevonyt have you done python with pyiodide (https://pyodide.org/en/stable/)? |
hey fellas, thank you for your help and hope you had nice holidays! @shakkernerd thats exciting to hear you may allow python in! that will really open the doors to the quant world. as you mentioned we use packages like pandas, numpy, talib, pandas_ta, scikitlearn, matplotlib and more and those packages are scaring me from converting to typescript @doxometrist super helpful resources, thank you for sending. i had never heard of pyodide but after researching it a bit it seems like a great solution to atleast do a proof of concept. i will start looking into how i can get eliza to interact with my python code via pyodide and get back to you. pyodide looks really neat - ive been wanting to run py on web, i appreciate the share |
sup fam, i was able to convert my entire python code to typescript and get actions set up for each of the buy, sell, stop loss, breakout, etc functions. been having a bit of trouble implementing it into the agent tho. should i push the new code how it is, or keep working on getting it implemented into eliza first? |
I’d just finish getting it integrated into the agent. If you need help, we’re on discord |
sup fam, today i put in a few hours to extend the Eliza framework by adding some core trading functionality for on-chain solana bots. my focus was to create a set of tools that will allow agents to execute trades, manage risk, and pull critical data. here's what I added and worked on:
What I Added/Completed Today:
Why This Matters:
What's Next?
Thanks for the opportunity to contribute. Let me know if there’s anything you’d like me to adjust or refine for tomorrow.