Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken ci docs missed frozen pnpm file out-of-sync #1798

Merged

Conversation

marcellodesales
Copy link
Contributor

@marcellodesales marcellodesales commented Jan 4, 2025

◀️ Relates to:

Fixes the build related to the pnpm-lock not being in sync from the docs/ dir

⚠️ Risks

  • low: the build locally in an isolated docker image seems to be working

🖼️ Background

What does this PR do?

  • Fixes the current build that's broken

What kind of change is this?

  • Bug fixes (non-breaking change which fixes an issue)

Why are we doing this? Any context or related work?

Because I broke the build :)

📚 Documentation changes needed?

  • We should be adding docs about requiring users to update the lock files before pushing the changes.

NOTE: @madjin should we add a check for those in CI?

✅ Testing

Where should a reviewer start?

  • Start with running pnpm install --frozen-lockfile from the root dir
root@21bdd5ef97fb:/Users/marcellodesales/dev/github.com/elizaOS/eliza# pnpm install --frozen-lockfile
! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.12.3.tgz
? Do you want to continue? [Y/n] y

Scope: all 55 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +4765
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

   ╭──────────────────────────────────────────────────────────────────╮
   │                                                                  │
   │                Update available! 9.12.3 → 9.15.2.                │
   │   Changelog: https://github.com/pnpm/pnpm/releases/tag/v9.15.2   │
   │         Run "corepack install -g pnpm@9.15.2" to update.         │
   │                                                                  │
   │         Follow @pnpmjs for updates: https://x.com/pnpmjs         │
   │                                                                  │
   ╰──────────────────────────────────────────────────────────────────╯

Progress: resolved 0, reused 2402, downloaded 0, added 0

Detailed testing steps

Screenshots

Before

root@ddda7177349e:/Users/marcellodesales/dev/github.com/elizaOS/eliza# pnpm install
! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.12.3.tgz
? Do you want to continue? [Y/n] y

Scope: all 55 workspace projects
 ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with <ROOT>/docs/package.json

Note that in CI environments this setting is true by default. If you still need to run install in such cases, use "pnpm install --no-frozen-lockfile"

    Failure reason:
    specifiers in the lockfile ({"@docusaurus/core":"3.6.3","@docusaurus/plugin-content-blog":"3.6.3","@docusaurus/plugin-content-docs":"3.6.3","@docusaurus/plugin-ideal-image":"3.6.3","@docusaurus/preset-classic":"3.6.3","@docusaurus/theme-mermaid":"3.6.3","@mdx-js/react":"3.0.1","clsx":"2.1.1","docusaurus-lunr-search":"3.5.0","dotenv":"^16.4.7","prism-react-renderer":"2.3.1","react":"18.3.1","react-dom":"18.3.1","react-router-dom":"6.22.1","@docusaurus/module-type-aliases":"3.6.3","@docusaurus/types":"3.6.3","docusaurus-plugin-typedoc":"1.0.5","typedoc":"0.26.11","typedoc-plugin-markdown":"4.2.10"}) don't match specs in package.json ({"@docusaurus/module-type-aliases":"3.6.3","@docusaurus/types":"3.6.3","docusaurus-plugin-typedoc":"1.0.5","typedoc":"0.26.11","typedoc-plugin-markdown":"4.2.10","@docusaurus/core":"3.6.3","@docusaurus/plugin-content-blog":"3.6.3","@docusaurus/plugin-content-docs":"3.6.3","@docusaurus/plugin-ideal-image":"3.6.3","@docusaurus/preset-classic":"3.6.3","@docusaurus/theme-mermaid":"3.6.3","@docusaurus/theme-common":"3.6.3","@mdx-js/react":"3.0.1","clsx":"2.1.1","docusaurus-lunr-search":"3.5.0","lunr":"2.3.9","dotenv":"^16.4.7","prism-react-renderer":"2.3.1","react":"18.3.1","react-dom":"18.3.1","react-router-dom":"6.22.1"})

After

root@21bdd5ef97fb:/Users/marcellodesales/dev/github.com/elizaOS/eliza# pnpm install --frozen-lockfile
! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-9.12.3.tgz
? Do you want to continue? [Y/n] y

Scope: all 55 workspace projects
Lockfile is up to date, resolution step is skipped
Packages: +4765
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

   ╭──────────────────────────────────────────────────────────────────╮
   │                                                                  │
   │                Update available! 9.12.3 → 9.15.2.                │
   │   Changelog: https://github.com/pnpm/pnpm/releases/tag/v9.15.2   │
   │         Run "corepack install -g pnpm@9.15.2" to update.         │
   │                                                                  │
   │         Follow @pnpmjs for updates: https://x.com/pnpmjs         │
   │                                                                  │
   ╰──────────────────────────────────────────────────────────────────╯

Progress: resolved 0, reused 3982, downloaded 0, added 4765, done
node_modules/ffmpeg-static: Running install script, done in 19.9s
node_modules/canvas: Running install script, failed in 5.9s (skipped as optional)
node_modules/bufferutil: Running install script, done in 5.1s
node_modules/utf-8-validate: Running install script, done in 5.1s
node_modules/@discordjs/opus: Running install script, done in 24s
node_modules/@ffmpeg-installer/linux-arm64: Running postinstall script, done in 4ms
node_modules/@nestjs/core: Running postinstall script, done in 1.2s
node_modules/onnxruntime-node: Running postinstall script, done in 73ms
node_modules/keccak: Running install script, done in 2.9s
node_modules/@nomicfoundation/ethereumjs-tx/node_modules/secp256k1: Running install script, done in 3.8s
node_modules/bigint-buffer: Running install script, done in 814ms
node_modules/babel-runtime/node_modules/core-js: Running postinstall script, done in 18ms
node_modules/@near-js/crypto/node_modules/secp256k1: Running install script, done in 3.6s
node_modules/protobufjs: Running postinstall script, done in 17ms
node_modules/puppeteer: Running postinstall script, done in 29s
node_modules/es5-ext: Running postinstall script, done in 22ms
node_modules/tsx/node_modules/esbuild: Running postinstall script, done in 39ms
node_modules/wtf_wikipedia: Running postinstall script, done in 119ms
node_modules/@docusaurus/plugin-ideal-image/node_modules/sharp: Running install script, done in 10.7s
node_modules/@parcel/watcher: Running install script, done in 17ms
node_modules/unbuild/node_modules/esbuild: Running postinstall script, done in 38ms
node_modules/@multiversx/sdk-core/node_modules/keccak: Running install script, done in 2.5s
node_modules/node-llama-cpp: Running postinstall script, done in 638ms
node_modules/@openapitools/openapi-generator-cli: Running postinstall script, done in 1.5s
node_modules/nx: Running postinstall script, done in 253ms
node_modules/youtube-dl-exec: Running preinstall script, done in 95ms
node_modules/youtube-dl-exec: Running postinstall script, done in 5.8s
packages/plugin-node postinstall$ node scripts/postinstall.js
│ Skipping playwright installation on unsupported platform: linux
└─ Done in 19ms
Done in 3m 55.5s

-->

@marcellodesales marcellodesales force-pushed the bugfix/broken-ci-docs-missed-frozen branch from 9c31e1e to ca26f6e Compare January 4, 2025 04:06
@marcellodesales marcellodesales marked this pull request as ready for review January 4, 2025 04:18
@marcellodesales marcellodesales force-pushed the bugfix/broken-ci-docs-missed-frozen branch from ca26f6e to 7e1d037 Compare January 4, 2025 04:19
@marcellodesales marcellodesales changed the title Bugfix/broken ci docs missed frozen fix: broken ci docs missed frozen pnpm file out-of-sync Jan 4, 2025
@marcellodesales marcellodesales force-pushed the bugfix/broken-ci-docs-missed-frozen branch 3 times, most recently from 7e1d037 to 43e74e2 Compare January 4, 2025 04:44
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcellodesales marcellodesales force-pushed the bugfix/broken-ci-docs-missed-frozen branch from d136555 to 838fd7a Compare January 4, 2025 23:18
@marcellodesales
Copy link
Contributor Author

@monilpat I see the develop branch was merged into the branch and the integration tests broke... I rebased it again and pushed a new one.

@marcellodesales
Copy link
Contributor Author

@monilpat @odilitime @madjin we should have the CI also to run in PRs before they get into the develop branch... It infects other PRs before we merge and also break the regular development... Should we include the CI to run in any PR against develop?

@lalalune lalalune merged commit 3809da3 into elizaOS:develop Jan 5, 2025
3 of 5 checks passed
@marcellodesales marcellodesales deleted the bugfix/broken-ci-docs-missed-frozen branch January 6, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants